mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] AC97: Print AC97 flags in proc file to make debug it easier
@ 2009-01-28 17:39 Thadeu Lima de Souza Cascardo
  2009-01-29  8:07 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2009-01-28 17:39 UTC (permalink / raw)
  To: tiwai; +Cc: linux-kernel, Thadeu Lima de Souza Cascardo

While debugging some code paths in AC97 codec patches and its suspend
and resume functions, getting to know the flags has proved useful to
follow those code paths.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
 sound/pci/ac97/ac97_proc.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/pci/ac97/ac97_proc.c b/sound/pci/ac97/ac97_proc.c
index 060ea59..73b17d5 100644
--- a/sound/pci/ac97/ac97_proc.c
+++ b/sound/pci/ac97/ac97_proc.c
@@ -125,6 +125,8 @@ static void snd_ac97_proc_read_main(struct snd_ac97 *ac97, struct snd_info_buffe
         snd_iprintf(buffer, "PCI Subsys Device: 0x%04x\n\n",
                     ac97->subsystem_device);
 
+	snd_iprintf(buffer, "Flags: %x\n", ac97->flags);
+
 	if ((ac97->ext_id & AC97_EI_REV_MASK) >= AC97_EI_REV_23) {
 		val = snd_ac97_read(ac97, AC97_INT_PAGING);
 		snd_ac97_update_bits(ac97, AC97_INT_PAGING,
-- 
1.6.0.6


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] AC97: Print AC97 flags in proc file to make debug it easier
  2009-01-28 17:39 [PATCH] AC97: Print AC97 flags in proc file to make debug it easier Thadeu Lima de Souza Cascardo
@ 2009-01-29  8:07 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-01-29  8:07 UTC (permalink / raw)
  To: Thadeu Lima de Souza Cascardo; +Cc: linux-kernel

At Wed, 28 Jan 2009 15:39:22 -0200,
Thadeu Lima de Souza Cascardo wrote:
> 
> While debugging some code paths in AC97 codec patches and its suspend
> and resume functions, getting to know the flags has proved useful to
> follow those code paths.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Applied.  Thanks.


Takashi

> ---
>  sound/pci/ac97/ac97_proc.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/ac97/ac97_proc.c b/sound/pci/ac97/ac97_proc.c
> index 060ea59..73b17d5 100644
> --- a/sound/pci/ac97/ac97_proc.c
> +++ b/sound/pci/ac97/ac97_proc.c
> @@ -125,6 +125,8 @@ static void snd_ac97_proc_read_main(struct snd_ac97 *ac97, struct snd_info_buffe
>          snd_iprintf(buffer, "PCI Subsys Device: 0x%04x\n\n",
>                      ac97->subsystem_device);
>  
> +	snd_iprintf(buffer, "Flags: %x\n", ac97->flags);
> +
>  	if ((ac97->ext_id & AC97_EI_REV_MASK) >= AC97_EI_REV_23) {
>  		val = snd_ac97_read(ac97, AC97_INT_PAGING);
>  		snd_ac97_update_bits(ac97, AC97_INT_PAGING,
> -- 
> 1.6.0.6
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-29  8:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-28 17:39 [PATCH] AC97: Print AC97 flags in proc file to make debug it easier Thadeu Lima de Souza Cascardo
2009-01-29  8:07 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®