* [PATCH] ALSA: pci: echoaudio: remove variable which is a constant
@ 2019-06-13 16:04 Wolfram Sang
2019-06-13 16:40 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2019-06-13 16:04 UTC (permalink / raw)
To: alsa-devel; +Cc: Wolfram Sang, Jaroslav Kysela, Takashi Iwai, linux-kernel
Checking a variable which is always '1' has no use.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Only build tested. Found by static code analysis of similar patterns.
sound/pci/echoaudio/echoaudio_dsp.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/pci/echoaudio/echoaudio_dsp.c b/sound/pci/echoaudio/echoaudio_dsp.c
index b181752b8481..50d4a87a6bb3 100644
--- a/sound/pci/echoaudio/echoaudio_dsp.c
+++ b/sound/pci/echoaudio/echoaudio_dsp.c
@@ -1058,7 +1058,6 @@ static int allocate_pipes(struct echoaudio *chip, struct audiopipe *pipe,
{
int i;
u32 channel_mask;
- char is_cyclic;
dev_dbg(chip->card->dev,
"allocate_pipes: ch=%d int=%d\n", pipe_index, interleave);
@@ -1066,8 +1065,6 @@ static int allocate_pipes(struct echoaudio *chip, struct audiopipe *pipe,
if (chip->bad_board)
return -EIO;
- is_cyclic = 1; /* This driver uses cyclic buffers only */
-
for (channel_mask = i = 0; i < interleave; i++)
channel_mask |= 1 << (pipe_index + i);
if (chip->pipe_alloc_mask & channel_mask) {
@@ -1078,8 +1075,8 @@ static int allocate_pipes(struct echoaudio *chip, struct audiopipe *pipe,
chip->comm_page->position[pipe_index] = 0;
chip->pipe_alloc_mask |= channel_mask;
- if (is_cyclic)
- chip->pipe_cyclic_mask |= channel_mask;
+ /* This driver uses cyclic buffers only */
+ chip->pipe_cyclic_mask |= channel_mask;
pipe->index = pipe_index;
pipe->interleave = interleave;
pipe->state = PIPE_STATE_STOPPED;
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: pci: echoaudio: remove variable which is a constant
2019-06-13 16:04 [PATCH] ALSA: pci: echoaudio: remove variable which is a constant Wolfram Sang
@ 2019-06-13 16:40 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-06-13 16:40 UTC (permalink / raw)
To: Wolfram Sang; +Cc: alsa-devel, Jaroslav Kysela, linux-kernel
On Thu, 13 Jun 2019 18:04:23 +0200,
Wolfram Sang wrote:
>
> Checking a variable which is always '1' has no use.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> Only build tested. Found by static code analysis of similar patterns.
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-13 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 16:04 [PATCH] ALSA: pci: echoaudio: remove variable which is a constant Wolfram Sang
2019-06-13 16:40 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®