From: Takashi Iwai <tiwai@suse.de>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
ALSA devel <alsa-devel@alsa-project.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [ALSA] ISA drivers bailing on first IS_ERR
Date: Fri, 24 Mar 2006 12:09:11 +0100 [thread overview]
Message-ID: <s5hslp8nlpk.wl%tiwai@suse.de> (raw)
In-Reply-To: <4423848E.9030805@keyaccess.nl>
At Fri, 24 Mar 2006 06:33:02 +0100,
Rene Herman wrote:
>
> Hi Takashi.
>
> If as per the previous message an error return from the probe() method
> should make platform_driver_register_simple() return IS_ERR, then the
> SNDRV_CARDS loop should continue with the next one, instead of bailing.
>
> If the bus_add_device() patch and the attached is applied, the pre
> platform_driver behaviour of not loading on not finding any devices (and
> printing a message to that effect) is restored. Without, the printk is
> dead code.
>
> This has been generated against 2.6.16 + the earlier !enable[i] patch.
These looks OK to me. Could you regenerate patches against the latest
git (or ALSA CVS) ?
Or, it might be better against to mm tree, since pnp registrations
will be modified there, too. They should go also to mainstream
together.
Nevertheless, the patches (this and the previous one) are good to go
to stable tree, too.
thanks,
Takashi
next prev parent reply other threads:[~2006-03-24 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 5:33 Rene Herman
2006-03-24 11:09 ` Takashi Iwai [this message]
2006-03-25 0:39 ` Rene Herman
2006-03-27 21:59 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hslp8nlpk.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®