* [PATCH] ALSA: info: remove redundant assignment to variable c
@ 2020-02-08 22:42 Colin King
2020-02-10 7:31 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-02-08 22:42 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable c is being assigned with the value -1 that is never read,
it is assigned a new value in a following while-loop. The assignment
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/core/info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/info.c b/sound/core/info.c
index ca87ae4c30ba..8c6bc5241df5 100644
--- a/sound/core/info.c
+++ b/sound/core/info.c
@@ -604,7 +604,7 @@ int snd_info_card_free(struct snd_card *card)
*/
int snd_info_get_line(struct snd_info_buffer *buffer, char *line, int len)
{
- int c = -1;
+ int c;
if (snd_BUG_ON(!buffer || !buffer->buffer))
return 1;
--
2.25.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: info: remove redundant assignment to variable c
2020-02-08 22:42 [PATCH] ALSA: info: remove redundant assignment to variable c Colin King
@ 2020-02-10 7:31 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-02-10 7:31 UTC (permalink / raw)
To: Colin King
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors, linux-kernel
On Sat, 08 Feb 2020 23:42:06 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable c is being assigned with the value -1 that is never read,
> it is assigned a new value in a following while-loop. The assignment
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 22:42 [PATCH] ALSA: info: remove redundant assignment to variable c Colin King
2020-02-10 7:31 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®