From: Takashi Iwai <tiwai@suse.de>
To: " Maciej S. Szmigiero " <mail@maciej.szmigiero.name>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/5] ALSA: emu10k1: remove reserved_page
Date: Wed, 14 Feb 2018 07:47:40 +0100 [thread overview]
Message-ID: <s5htvuk1303.wl-tiwai@suse.de> (raw)
In-Reply-To: <87e066a9-99ec-31a4-111a-1d848b7d98ec@maciej.szmigiero.name>
On Wed, 14 Feb 2018 00:04:58 +0100,
Maciej S. Szmigiero wrote:
>
> The emu10k1-family chips need the first page (index 0) reserved in their
> page tables for some reason (every emu10k1 driver I've checked does this
> without much of an explanation).
> Using the first page for normal samples results in a broken playback.
>
> However, we already have a dummy page allocated - so called "silent page"
> and, in fact, had always been setting it as the first page in the chip page
> table because an initialization of every entry of the page table to point
> to a silent page happens after and overwrites the reserved_page allocation.
>
> So the only thing remaining to remove the reserved_page allocation is a
> trivial change to the page allocation logic to ignore the first page entry
> and start its allocations from the second entry (index 1).
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
> Changes from v1, v2: None in this patch.
Thanks, applied all 5 patches now.
Takashi
prev parent reply other threads:[~2018-02-14 6:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 23:04 Maciej S. Szmigiero
2018-02-14 6:47 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htvuk1303.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome