From: Takashi Iwai <tiwai@suse.de>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: perex@perex.cz, yongjun_wei@trendmicro.com.cn,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - remove unused variable in azx_position_ok()
Date: Mon, 22 Oct 2012 11:00:17 +0200 [thread overview]
Message-ID: <s5htxtmj2zi.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAPgLHd9ydHRoc_Zd43=Fedfn61S3NxBcAoqoOq=cFutjRuPpoA@mail.gmail.com>
At Mon, 22 Oct 2012 16:30:10 +0800,
Wei Yongjun wrote:
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable stream is initialized but never used
> otherwise, so remove the unused variable.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thanks, applied.
Takashi
> ---
> sound/pci/hda/hda_intel.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 72b085a..0ceed85 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2193,13 +2193,11 @@ static int azx_position_ok(struct azx *chip, struct azx_dev *azx_dev)
> {
> u32 wallclk;
> unsigned int pos;
> - int stream;
>
> wallclk = azx_readl(chip, WALLCLK) - azx_dev->start_wallclk;
> if (wallclk < (azx_dev->period_wallclk * 2) / 3)
> return -1; /* bogus (too early) interrupt */
>
> - stream = azx_dev->substream->stream;
> pos = azx_get_position(chip, azx_dev, true);
>
> if (WARN_ONCE(!azx_dev->period_bytes,
>
prev parent reply other threads:[~2012-10-22 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 8:30 Wei Yongjun
2012-10-22 9:00 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htxtmj2zi.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome