mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Nick Simonov" <nicksimonovv@gmail.com>
Cc: <oleksandr_andrushchenko@epam.com>, <alsa-devel@alsa-project.org>,
	<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops
Date: Fri, 21 Sep 2018 11:23:48 +0200	[thread overview]
Message-ID: <s5hva6z2ogr.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180921092135.GA20633@kbp1-dhp-f54120>

On Fri, 21 Sep 2018 11:21:35 +0200,
Nick Simonov wrote:
> 
> On Fri, Sep 21, 2018 at 08:51:51AM +0200, Takashi Iwai wrote:
> > On Fri, 21 Sep 2018 07:47:38 +0200,
> > Nick Simonov wrote:
> > > 
> > > snd_pcm_ops are not supposed to change. So mark the
> > > non-const structs as const. Also, refine indentation
> > > to increase readability.
> > > 
> > > Signed-off-by: Nick Simonov <nicksimonovv@gmail.com>
> > > ---
> > > Changes v2:
> > > - Fix typo in commit description, ncrease to increase.
> > 
> > Since I already merged your first version, please resubmit as an
> > incremental patch.  At best, check the latest linux-next or my
> > sound.git tree for-next branch, and create a patch on its top.
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> Sorry I want to clarify, there is no mistakes in the code itself
> there is a typo in commit message. As I now there is no way to change
> commit message without rebase after merge, so which is the proper way in
> this case? leave it as is?

Then let's leave as is.


thanks,

Takashi

      reply	other threads:[~2018-09-21  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180921054514.GA11771@nick>
2018-09-21  6:51 ` [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops, " Takashi Iwai
2018-09-21  9:21   ` Nick Simonov
2018-09-21  9:23     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hva6z2ogr.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicksimonovv@gmail.com \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®