From: Takashi Iwai <tiwai@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [Alsa-devel] [2.6 patch] make sound/isa/gus/gusextreme.c:devices static
Date: Tue, 11 Jul 2006 12:17:11 +0200 [thread overview]
Message-ID: <s5hveq4xx7c.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060710220236.GI13938@stusta.de>
At Tue, 11 Jul 2006 00:02:36 +0200,
Adrian Bunk wrote:
>
> "devices" is not a good name for a global variable.
>
> Thankfully, it can become static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Applied to ALSA tree now. Thanks.
Takashi
>
> --- linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c.old 2006-07-10 01:15:13.000000000 +0200
> +++ linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c 2006-07-10 01:15:20.000000000 +0200
> @@ -87,7 +87,7 @@
> module_param_array(pcm_channels, int, NULL, 0444);
> MODULE_PARM_DESC(pcm_channels, "Reserved PCM channels for GUS Extreme driver.");
>
> -struct platform_device *devices[SNDRV_CARDS];
> +static struct platform_device *devices[SNDRV_CARDS];
>
>
> #define PFX "gusextreme: "
>
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
>
prev parent reply other threads:[~2006-07-11 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 22:02 Adrian Bunk
2006-07-11 10:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hveq4xx7c.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®