Re: [PATCH] sound: pci: ctxfi: pr_* replaced with dev_*

[Takashi Iwai <tiwai@suse.de>]

At Fri, 12 Sep 2014 16:15:45 +0530,
Sudip Mukherjee wrote:
> 
> pr_* macros replaced with dev_* as they are more preffered over pr_*.

Now we have card->dev as its own device.  Use this instead of
pci->dev as much as possible.  (Of course, you should be careful about
the object's lifetime, too).  Also...

> diff --git a/sound/pci/ctxfi/ctamixer.c b/sound/pci/ctxfi/ctamixer.c
> index fed6e6a..d08b8b6 100644
> --- a/sound/pci/ctxfi/ctamixer.c
> +++ b/sound/pci/ctxfi/ctamixer.c
> @@ -258,7 +258,8 @@ static int get_amixer_rsc(struct amixer_mgr *mgr,
>  	}
>  	spin_unlock_irqrestore(&mgr->mgr_lock, flags);
>  	if (err) {
> -		pr_err("ctxfi: Can't meet AMIXER resource request!\n");
> +		dev_err(&(((struct hw *)(mgr->mgr.hw))->pci->dev),
> +			"ctxfi: Can't meet AMIXER resource request!\n");

... please re-read and consider twice before submitting your patch,
whether such a change is really good or not.


thanks,

Takashi