From: Takashi Iwai <tiwai@suse.de>
To: "Stefan Agner" <stefan@agner.ch>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: ctxfi: use enum type CT_SUM_CTL where appropriate
Date: Mon, 18 Jun 2018 17:40:48 +0200 [thread overview]
Message-ID: <s5hy3fcw1a7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180617134652.1638-1-stefan@agner.ch>
On Sun, 17 Jun 2018 15:46:49 +0200,
Stefan Agner wrote:
>
> Currently a variable of type enum CT_AMIXER_CTL is used for enum
> CT_SUM_CTL values. This leads to warnings when using clang:
> sound/pci/ctxfi/ctmixer.c:945:32: warning: implicit conversion from enumeration type
> 'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
> [-Wenum-conversion]
> for (i = AMIXER_MASTER_F, j = SUM_IN_F;
> ~ ^~~~~~~~
> sound/pci/ctxfi/ctmixer.c:975:29: warning: implicit conversion from enumeration type
> 'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL'
> [-Wenum-conversion]
> for (i = AMIXER_PCM_F, j = SUM_IN_F; i <= AMIXER_PCM_S; i++, j++) {
> ~ ^~~~~~~~
>
> Introduce enum CT_SUM_CTL k and it instead.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Applied, thanks.
Takashi
prev parent reply other threads:[~2018-06-18 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 13:46 Stefan Agner
2018-06-18 15:40 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy3fcw1a7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®