From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com,
vinod.koul@intel.com, broonie@kernel.org,
andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org
Subject: Re: [alsa-devel] [RFC PATCH 3/7] ASoC: Intel: document what Kconfig options do
Date: Tue, 21 Nov 2017 18:09:24 +0100 [thread overview]
Message-ID: <s5hy3mztv7f.wl-tiwai@suse.de> (raw)
In-Reply-To: <20171118000202.22302-4-pierre-louis.bossart@linux.intel.com>
On Sat, 18 Nov 2017 01:01:58 +0100,
Pierre-Louis Bossart wrote:
>
> Document what the options are supposed to mean, before clean-up in
> next patch.
>
> No functionality change here.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/Kconfig | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 175b2965ca21..136426d60da0 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -15,16 +15,30 @@ if SND_SOC_INTEL_SST_TOPLEVEL
>
> config SND_SST_IPC
> tristate
> + help
> + This option controls the IPC core for HiFi2 platforms
A help section for non-selectable config is fine, per se, but in most
cases it's written as a comment.
And, if we do add the help text, it's more important to do that for
selectable items. Currently the help texts are missing for the
platform configs like SND_SOC_INTEL_HASWELL.
thanks,
Takashi
next prev parent reply other threads:[~2017-11-21 17:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 0:01 [RFC PATCH 0/7] Fix Intel audio Kconfig issues Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Pierre-Louis Bossart
2017-11-18 16:49 ` Takashi Iwai
2017-11-20 16:18 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-21 17:07 ` Takashi Iwai
2017-11-21 21:31 ` Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 2/7] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart
2017-11-18 16:53 ` Andy Shevchenko
2017-11-18 16:55 ` Shevchenko, Andriy
2017-11-20 16:23 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-20 16:58 ` Alan Cox
2017-11-21 12:05 ` Andy Shevchenko
2017-11-20 15:23 ` Alan Cox
2017-11-18 0:01 ` [RFC PATCH 3/7] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart
2017-11-21 17:09 ` Takashi Iwai [this message]
2017-11-21 21:32 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 4/7] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart
2017-11-18 0:02 ` [RFC PATCH 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart
2018-01-08 16:22 ` Applied "ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell" to the asoc tree Mark Brown
2017-11-18 0:02 ` [RFC PATCH 6/7] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart
2017-11-18 17:08 ` Andy Shevchenko
2017-11-20 16:27 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-18 0:02 ` [RFC PATCH 7/7] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart
2017-11-18 17:14 ` Andy Shevchenko
2017-11-18 0:09 ` [RFC PATCH 0/7] Fix Intel audio Kconfig issues Linus Torvalds
2017-11-18 9:25 ` Takashi Iwai
2017-11-20 13:28 ` Arnd Bergmann
2017-11-21 17:10 ` Takashi Iwai
2017-11-21 21:36 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-22 11:54 ` Mark Brown
2017-11-27 14:40 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy3mztv7f.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®