* [PATCH] sound: pci: rme9652: Unneeded variable: "result".
@ 2019-07-11 17:21 Hariprasad Kelam
2019-07-15 6:58 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-07-11 17:21 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Hariprasad Kelam, Richard Fontana,
Allison Randal, Greg Kroah-Hartman, Thomas Gleixner, alsa-devel,
linux-kernel
This patch fixes below issue reported by coccicheck
sound/pci/rme9652/rme9652.c:2161:5-11: Unneeded variable: "result".
Return "0" on line 2167
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
sound/pci/rme9652/rme9652.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/pci/rme9652/rme9652.c b/sound/pci/rme9652/rme9652.c
index cb9818a..4c851f8 100644
--- a/sound/pci/rme9652/rme9652.c
+++ b/sound/pci/rme9652/rme9652.c
@@ -2158,13 +2158,12 @@ static int snd_rme9652_prepare(struct snd_pcm_substream *substream)
{
struct snd_rme9652 *rme9652 = snd_pcm_substream_chip(substream);
unsigned long flags;
- int result = 0;
spin_lock_irqsave(&rme9652->lock, flags);
if (!rme9652->running)
rme9652_reset_hw_pointer(rme9652);
spin_unlock_irqrestore(&rme9652->lock, flags);
- return result;
+ return 0;
}
static const struct snd_pcm_hardware snd_rme9652_playback_subinfo =
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: pci: rme9652: Unneeded variable: "result".
2019-07-11 17:21 [PATCH] sound: pci: rme9652: Unneeded variable: "result" Hariprasad Kelam
@ 2019-07-15 6:58 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-07-15 6:58 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: alsa-devel, Thomas Gleixner, Greg Kroah-Hartman, Allison Randal,
Jaroslav Kysela, Richard Fontana, Takashi Iwai, linux-kernel
On Thu, 11 Jul 2019 19:21:07 +0200,
Hariprasad Kelam wrote:
>
> This patch fixes below issue reported by coccicheck
>
> sound/pci/rme9652/rme9652.c:2161:5-11: Unneeded variable: "result".
> Return "0" on line 2167
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-15 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11 17:21 [PATCH] sound: pci: rme9652: Unneeded variable: "result" Hariprasad Kelam
2019-07-15 6:58 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®