From: Takashi Iwai <tiwai@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ALSA: ice1712: remove unused variable
Date: Fri, 14 Nov 2014 11:52:18 +0100 [thread overview]
Message-ID: <s5hzjbugil9.wl-tiwai@suse.de> (raw)
In-Reply-To: <1415961547-10330-3-git-send-email-sudipm.mukherjee@gmail.com>
At Fri, 14 Nov 2014 16:09:07 +0530,
Sudip Mukherjee wrote:
>
> buf_size was initialized with snd_pcm_lib_buffer_bytes,
> but never used. and so it is safe to be deleted.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Thanks, applied.
Takashi
> ---
> sound/pci/ice1712/ice1712.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
> index 5975334..6525191 100644
> --- a/sound/pci/ice1712/ice1712.c
> +++ b/sound/pci/ice1712/ice1712.c
> @@ -620,10 +620,9 @@ static int snd_ice1712_playback_ds_prepare(struct snd_pcm_substream *substream)
> {
> struct snd_ice1712 *ice = snd_pcm_substream_chip(substream);
> struct snd_pcm_runtime *runtime = substream->runtime;
> - u32 period_size, buf_size, rate, tmp, chn;
> + u32 period_size, rate, tmp, chn;
>
> period_size = snd_pcm_lib_period_bytes(substream) - 1;
> - buf_size = snd_pcm_lib_buffer_bytes(substream) - 1;
> tmp = 0x0064;
> if (snd_pcm_format_width(runtime->format) == 16)
> tmp &= ~0x04;
> --
> 1.8.1.2
>
next prev parent reply other threads:[~2014-11-14 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 10:39 [PATCH v2 1/3] ALSA: ice1712: remove unneeded return statement Sudip Mukherjee
2014-11-14 10:39 ` [PATCH v2 2/3] ALSA: ice1712: consider error value Sudip Mukherjee
2014-11-14 10:43 ` Takashi Iwai
2014-11-14 10:59 ` Sudip Mukherjee
2014-11-14 11:03 ` Takashi Iwai
2014-11-14 10:39 ` [PATCH v2 3/3] ALSA: ice1712: remove unused variable Sudip Mukherjee
2014-11-14 10:52 ` Takashi Iwai [this message]
2014-11-14 10:52 ` [PATCH v2 1/3] ALSA: ice1712: remove unneeded return statement Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzjbugil9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome