mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/6] ALSA: ctxfi: changed void * to struct hw *
Date: Tue, 30 Sep 2014 10:44:44 +0200	[thread overview]
Message-ID: <s5hzjdh4hvn.wl-tiwai@suse.de> (raw)
In-Reply-To: <1411981406-10611-1-git-send-email-sudipm.mukherjee@gmail.com>

At Mon, 29 Sep 2014 14:33:21 +0530,
Sudip Mukherjee wrote:
> 
> in the code we have void *hw and while using we are always typecasting
> it to (struct hw *). it is better to use void type of pointer when we
> store different types of pointer , but in this code we are only having
> struct hw.
> So changed all the relevant reference of void *hw to struct hw *hw,
> without any modification of the existing code logic.
> the next patch of the series will remove the typecasting which is
> not required now.

Thanks, all patches look much better now, so I took them.


Takashi

      parent reply	other threads:[~2014-09-30  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-29  9:03 Sudip Mukherjee
2014-09-29  9:03 ` [PATCH v5 2/6] ALSA: ctxfi: removed typecast to (struct hw *) Sudip Mukherjee
2014-09-29  9:03 ` [PATCH v5 3/6] ALSA: ctxfi: added reference of snd_card Sudip Mukherjee
2014-09-29  9:03 ` [PATCH v5 4/6] ALSA: ctxfi: initialized snd_card Sudip Mukherjee
2014-09-29  9:03 ` [PATCH v5 5/6] ALSA: ctxfi: ctatc: added reference to snd_card Sudip Mukherjee
2014-09-29  9:03 ` [PATCH v5 6/6] ALSA: ctxfi: pr_* replaced with dev_* Sudip Mukherjee
2014-09-30  8:44 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hzjdh4hvn.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®