mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hirokazu Takata <takata@linux-m32r.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Hirokazu Takata <takata@linux-m32r.org>,
	torvalds@osdl.org, linux-m32r@ml.linux-m32r.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m32r: use generic sys_pipe
Date: Fri, 09 May 2008 22:37:51 +0900	[thread overview]
Message-ID: <swfod7f38eo.wl%takata.hirokazu@renesas.com> (raw)
In-Reply-To: <20080509124402.GA14406@lst.de>

Hi, Christoph,

Please sign off this patch.

Thanks,

From: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] m32r: use generic sys_pipe
Date: Fri, 09 May 2008 14:44:02 +0200
> m32r can use the generic sys_pipe implementation.
> 
> The current sys_pipe implementation on m32r only differes from the
> generic one by passing a lot of additional unused registers to sys_pipe.
> 
> Reviewed and tested by Hirokazu Takata.

Signed-off-by: Hirokazu Takata <takata@linux-m32r.org>

> Index: linux-2.6/arch/m32r/kernel/sys_m32r.c
> ===================================================================
> --- linux-2.6.orig/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:10.000000000 +0200
> +++ linux-2.6/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:16.000000000 +0200
> @@ -76,29 +76,6 @@ asmlinkage int sys_tas(int __user *addr)
>  	return oldval;
>  }
>  
> -/*
> - * sys_pipe() is the normal C calling standard for creating
> - * a pipe. It's not the way Unix traditionally does this, though.
> - */
> -asmlinkage int
> -sys_pipe(unsigned long r0, unsigned long r1, unsigned long r2,
> -	unsigned long r3, unsigned long r4, unsigned long r5,
> -	unsigned long r6, struct pt_regs regs)
> -{
> -	int fd[2];
> -	int error;
> -
> -	error = do_pipe(fd);
> -	if (!error) {
> -		if (copy_to_user((void __user *)r0, fd, 2*sizeof(int))) {
> -			sys_close(fd[0]);
> -			sys_close(fd[1]);
> -			error = -EFAULT;
> -		}
> -	}
> -	return error;
> -}
> -
>  asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
>  	unsigned long prot, unsigned long flags,
>  	unsigned long fd, unsigned long pgoff)
> 

  reply	other threads:[~2008-05-09 13:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09 12:44 Christoph Hellwig
2008-05-09 13:37 ` Hirokazu Takata [this message]
2008-05-09 13:41   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=swfod7f38eo.wl%takata.hirokazu@renesas.com \
    --to=takata@linux-m32r.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m32r@ml.linux-m32r.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®