From: Shuai Liu <847807867@qq.com>
To: bryan.odonoghue@linaro.org
Cc: vladimir.zapolskiy@linaro.org, loic.poulain@oss.qualcomm.com,
mchehab@kernel.org, manivannan.sadhasivam@oss.qualcomm.com,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, 847807867@qq.com
Subject: [PATCH] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
Date: Mon, 2 Nov 2026 14:58:34 +0800 [thread overview]
Message-ID: <tencent_0D164F79882608DC3FB1B70913F736690207@qq.com> (raw)
Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
invisible bool gating phy-core-mipi-dphy.c where that helper lives.
With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
GENERIC_PHY_MIPI_DPHY, the build fails at link time:
camss-csiphy.c:(.text+0x51d): undefined reference to
`phy_mipi_dphy_get_default_config_for_hsclk'
Select GENERIC_PHY_MIPI_DPHY, matching the other MIPI D-PHY consumers
such as rkisp1, mali-c55, cadence-csi2rx and sun6i-mipi-csi2.
Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
Signed-off-by: Shuai Liu <847807867@qq.com>
---
drivers/media/platform/qcom/camss/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
index b51745c942c9..b18ae4405502 100644
--- a/drivers/media/platform/qcom/camss/Kconfig
+++ b/drivers/media/platform/qcom/camss/Kconfig
@@ -8,4 +8,5 @@ config VIDEO_QCOM_CAMSS
select VIDEOBUF2_DMA_SG
select V4L2_FWNODE
select GENERIC_PHY
+ select GENERIC_PHY_MIPI_DPHY
imply PHY_QCOM_MIPI_CSI2
--
2.43.0
next reply other threads:[~2026-11-02 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 6:58 Shuai Liu [this message]
2026-11-02 8:51 ` Loic Poulain
2026-11-02 9:20 ` [PATCH v2] " Shuai Liu
2026-11-04 0:28 ` Vladimir Zapolskiy
2026-11-04 1:11 ` [PATCH v3] " Shuai Liu
2026-11-04 8:17 ` Loic Poulain
2026-11-04 13:32 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_0D164F79882608DC3FB1B70913F736690207@qq.com \
--to=847807867@qq.com \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®