From: Shuai Liu <847807867@qq.com>
To: linux-media@vger.kernel.org
Cc: bryan.odonoghue@linaro.org, vladimir.zapolskiy@linaro.org,
mchehab@kernel.org, manivannan.sadhasivam@oss.qualcomm.com,
loic.poulain@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
Date: Wed, 4 Nov 2026 09:11:00 +0800 [thread overview]
Message-ID: <tencent_C589954C94BAFF49A7B030C93F367DE1620A@qq.com> (raw)
In-Reply-To: <aa7b58df-a7df-4d33-b2a5-9cc760dd9ed5@linaro.org>
Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
invisible bool gating phy-core-mipi-dphy.c where that helper lives.
With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
GENERIC_PHY_MIPI_DPHY, the build fails at link time:
camss-csiphy.c:(.text+0x51d): undefined reference to
`phy_mipi_dphy_get_default_config_for_hsclk'
Select GENERIC_PHY_MIPI_DPHY and drop the explicit "select GENERIC_PHY",
which is redundant as GENERIC_PHY_MIPI_DPHY selects GENERIC_PHY
transitively (drivers/phy/Kconfig). This matches the other MIPI D-PHY
consumers such as rkisp1, mali-c55 and sun6i-mipi-csi2.
Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
Signed-off-by: Shuai Liu <847807867@qq.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
Changes in v3:
- collect Reviewed-by tag
Changes in v2:
- drop the redundant "select GENERIC_PHY", as suggested by Loic
Poulain; GENERIC_PHY_MIPI_DPHY selects it transitively
---
drivers/media/platform/qcom/camss/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
index b51745c942c9..e0cef2cdd0a1 100644
--- a/drivers/media/platform/qcom/camss/Kconfig
+++ b/drivers/media/platform/qcom/camss/Kconfig
@@ -7,5 +7,5 @@ config VIDEO_QCOM_CAMSS
select VIDEO_V4L2_SUBDEV_API
select VIDEOBUF2_DMA_SG
select V4L2_FWNODE
- select GENERIC_PHY
+ select GENERIC_PHY_MIPI_DPHY
imply PHY_QCOM_MIPI_CSI2
--
2.43.0
prev parent reply other threads:[~2026-11-04 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 6:58 [PATCH] " Shuai Liu
2026-11-02 8:51 ` Loic Poulain
2026-11-02 9:20 ` [PATCH v2] " Shuai Liu
2026-11-04 0:28 ` Vladimir Zapolskiy
2026-11-04 1:11 ` Shuai Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_C589954C94BAFF49A7B030C93F367DE1620A@qq.com \
--to=847807867@qq.com \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®