* [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
[not found] <tencent_C2E4FE9B7C0A05615861782611715EAA9C0A@qq.com>
@ 2026-10-30 7:30 ` Yingjie Wang
2026-10-30 7:33 ` netdev-bot+sinfo
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Yingjie Wang @ 2026-10-30 7:30 UTC (permalink / raw)
To: netdev
Cc: dsahern, idosch, davem, edumazet, kuba, pabeni, horms,
alexhenrie24, linux-kernel
ipv6_create_tempaddr() raises a temporary address's preferred lifetime to
regen_advance + age + 1 when the configured lifetime is too short. The
result is stored in a u32, while regen_advance and age are unsigned long.
If the sum wraps or is truncated, the stored lifetime can still be less
than or equal to regen_advance + age.
addrconf_verify_rtnl() then sees the new address as due for regeneration
and creates another one. Temporary addresses are not limited by
max_addresses since commit 4b08a8f1bd8c ("ipv6: remove max_addresses
check from ipv6_create_tempaddr"), so this can cause unbounded address
growth. With dad_transmits set to -1, a baseline kernel reached 2859
loopback addresses in two seconds.
After storing the adjusted lifetime, verify that it is still greater than
regen_advance + age. Reject the new address if the check fails.
On an x86-64 KASAN kernel, the normal configuration created three IPv6
addresses. The negative dad_transmits, positive multiplication overflow,
and large retransmission-time cases each left only the loopback and public
addresses. An i386 defconfig and an x86-64 allmodconfig both built
addrconf.o with W=1.
Fixes: f4bcbf360ac8 ("net: ipv6/addrconf: clamp preferred_lft to the minimum required")
Cc: stable@vger.kernel.org
Suggested-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/netdev/20261029175827.GA1411453@shredder/
Signed-off-by: Yingjie Wang <1075151112@qq.com>
---
Changes in v3:
- Replace the broad input and arithmetic changes with the post-assignment
check suggested by Ido Schimmel.
- Preserve the existing sysctl interface and leave the advance calculation,
desynchronization handling and verification path unchanged.
- Rebase onto net/main at 5838f10563d5 and rerun the focused runtime and
cross-architecture build checks.
net/ipv6/addrconf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index c8c0dd04982d9..d9d13e78bf13b 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1487,7 +1487,8 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block)
age = (now - tmp_tstamp + ADDRCONF_TIMER_FUZZ_MINUS) / HZ;
if (cfg.preferred_lft <= regen_advance + age) {
cfg.preferred_lft = regen_advance + age + 1;
- if (cfg.preferred_lft > cfg.valid_lft ||
+ if (cfg.preferred_lft <= regen_advance + age ||
+ cfg.preferred_lft > cfg.valid_lft ||
cfg.preferred_lft > if_public_preferred_lft) {
in6_ifa_put(ifp);
in6_dev_put(idev);
base-commit: 5838f10563d58afca6711edb5e4eda968ca181d9
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-10-30 7:30 ` [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes Yingjie Wang
@ 2026-10-30 7:33 ` netdev-bot+sinfo
2026-10-30 13:43 ` Ido Schimmel
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: netdev-bot+sinfo @ 2026-10-30 7:33 UTC (permalink / raw)
To: Yingjie Wang
Cc: netdev, dsahern, idosch, davem, edumazet, kuba, pabeni, horms,
alexhenrie24, linux-kernel
Hi!
This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:
- How the issue was discovered, e.g. hit in production, hit during
development, syzbot report, manual code inspection, LLM or static
analysis tool scan.
Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.
The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-10-30 7:30 ` [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes Yingjie Wang
2026-10-30 7:33 ` netdev-bot+sinfo
@ 2026-10-30 13:43 ` Ido Schimmel
2026-10-31 17:22 ` Alex Henrie
2026-10-31 11:44 ` Xia Yan
2026-11-02 21:40 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 10+ messages in thread
From: Ido Schimmel @ 2026-10-30 13:43 UTC (permalink / raw)
To: Yingjie Wang
Cc: netdev, dsahern, davem, edumazet, kuba, pabeni, horms,
alexhenrie24, linux-kernel
On Fri, Oct 30, 2026 at 03:30:56PM +0800, Yingjie Wang wrote:
> ipv6_create_tempaddr() raises a temporary address's preferred lifetime to
> regen_advance + age + 1 when the configured lifetime is too short. The
> result is stored in a u32, while regen_advance and age are unsigned long.
> If the sum wraps or is truncated, the stored lifetime can still be less
> than or equal to regen_advance + age.
>
> addrconf_verify_rtnl() then sees the new address as due for regeneration
> and creates another one. Temporary addresses are not limited by
> max_addresses since commit 4b08a8f1bd8c ("ipv6: remove max_addresses
> check from ipv6_create_tempaddr"), so this can cause unbounded address
> growth. With dad_transmits set to -1, a baseline kernel reached 2859
> loopback addresses in two seconds.
>
> After storing the adjusted lifetime, verify that it is still greater than
> regen_advance + age. Reject the new address if the check fails.
>
> On an x86-64 KASAN kernel, the normal configuration created three IPv6
> addresses. The negative dad_transmits, positive multiplication overflow,
> and large retransmission-time cases each left only the loopback and public
> addresses. An i386 defconfig and an x86-64 allmodconfig both built
> addrconf.o with W=1.
>
> Fixes: f4bcbf360ac8 ("net: ipv6/addrconf: clamp preferred_lft to the minimum required")
> Cc: stable@vger.kernel.org
> Suggested-by: Ido Schimmel <idosch@nvidia.com>
> Link: https://lore.kernel.org/netdev/20261029175827.GA1411453@shredder/
> Signed-off-by: Yingjie Wang <1075151112@qq.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-10-30 7:30 ` [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes Yingjie Wang
2026-10-30 7:33 ` netdev-bot+sinfo
2026-10-30 13:43 ` Ido Schimmel
@ 2026-10-31 11:44 ` Xia Yan
2026-10-31 18:36 ` Yingjie Wang
2026-11-01 22:08 ` Alex Henrie
2026-11-02 21:40 ` patchwork-bot+netdevbpf
3 siblings, 2 replies; 10+ messages in thread
From: Xia Yan @ 2026-10-31 11:44 UTC (permalink / raw)
To: Yingjie Wang
Cc: netdev, dsahern, idosch, davem, edumazet, kuba, pabeni, horms,
alexhenrie24, linux-kernel, yana06070
Hi,
One question on the clamp added by f4bcbf360ac8, separate from the
wrap fixed here - I don't think this patch needs to address it. I have
only followed the source and have not run this case.
As far as I can tell the clamp's termination relies on cfg.valid_lft
and if_public_preferred_lft being finite. Consider a public address
with both lifetimes at INFINITY_LIFETIME and a large regen_advance,
with no wrap involved. For example with regen_min_advance=2,
regen_max_retry=3, dad_transmits=1, an RA Retrans Timer around
28,600,000 ms and HZ=1000, regen_advance is around 85802; raising
regen_max_retry via sysctl has the same effect.
If temp_prefered_lft is set below regen_advance, the effective
max_desync_factor goes negative, desync_factor is reset to 0, and the
clamp engages on every creation. The clamped preferred lifetime
regen_advance + age + 1 then passes all three checks, including the
new one. But the temporary address inherits the public address's
tstamp, so addrconf_verify_rtnl() finds it due for regeneration one
second after each creation: one new temporary address per second,
each living about temp_valid_lft. Creation is only refused once age
grows enough that regen_advance + age + 1 exceeds cfg.valid_lft,
which here is just temp_valid_lft, so the accumulation is bounded,
but with the numbers above it can still reach tens of thousands of
addresses.
Is this finite-lifetime assumption part of the intended behavior of
the clamp, or would it be worth tightening separately?
Thanks,
Xia
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-10-30 13:43 ` Ido Schimmel
@ 2026-10-31 17:22 ` Alex Henrie
0 siblings, 0 replies; 10+ messages in thread
From: Alex Henrie @ 2026-10-31 17:22 UTC (permalink / raw)
To: Ido Schimmel
Cc: Yingjie Wang, netdev, dsahern, davem, edumazet, kuba, pabeni,
horms, linux-kernel
On Fri, Oct 30, 2026 at 7:43 AM Ido Schimmel <idosch@nvidia.com> wrote:
>
> On Fri, Oct 30, 2026 at 03:30:56PM +0800, Yingjie Wang wrote:
> > ipv6_create_tempaddr() raises a temporary address's preferred lifetime to
> > regen_advance + age + 1 when the configured lifetime is too short. The
> > result is stored in a u32, while regen_advance and age are unsigned long.
> > If the sum wraps or is truncated, the stored lifetime can still be less
> > than or equal to regen_advance + age.
> >
> > addrconf_verify_rtnl() then sees the new address as due for regeneration
> > and creates another one. Temporary addresses are not limited by
> > max_addresses since commit 4b08a8f1bd8c ("ipv6: remove max_addresses
> > check from ipv6_create_tempaddr"), so this can cause unbounded address
> > growth. With dad_transmits set to -1, a baseline kernel reached 2859
> > loopback addresses in two seconds.
> >
> > After storing the adjusted lifetime, verify that it is still greater than
> > regen_advance + age. Reject the new address if the check fails.
> >
> > On an x86-64 KASAN kernel, the normal configuration created three IPv6
> > addresses. The negative dad_transmits, positive multiplication overflow,
> > and large retransmission-time cases each left only the loopback and public
> > addresses. An i386 defconfig and an x86-64 allmodconfig both built
> > addrconf.o with W=1.
> >
> > Fixes: f4bcbf360ac8 ("net: ipv6/addrconf: clamp preferred_lft to the minimum required")
> > Cc: stable@vger.kernel.org
> > Suggested-by: Ido Schimmel <idosch@nvidia.com>
> > Link: https://lore.kernel.org/netdev/20261029175827.GA1411453@shredder/
> > Signed-off-by: Yingjie Wang <1075151112@qq.com>
>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Alex Henrie <alexhenrie24@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-10-31 11:44 ` Xia Yan
@ 2026-10-31 18:36 ` Yingjie Wang
2026-11-01 22:08 ` Alex Henrie
1 sibling, 0 replies; 10+ messages in thread
From: Yingjie Wang @ 2026-10-31 18:36 UTC (permalink / raw)
To: Xia Yan
Cc: netdev, David Ahern, Ido Schimmel, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Alex Henrie, linux-kernel, yana06070
Hi Xia,
Agreed, this is separate from the wrapped or truncated lifetime handled
by this patch. In the case you describe, the stored preferred lifetime
does not wrap, so the new check is not intended to reject it.
I have not tested that case or established whether the repeated
regeneration is intended. Thanks for the detailed analysis.
Thanks,
Yingjie
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-10-31 11:44 ` Xia Yan
2026-10-31 18:36 ` Yingjie Wang
@ 2026-11-01 22:08 ` Alex Henrie
2026-11-02 7:51 ` Xia Yan
1 sibling, 1 reply; 10+ messages in thread
From: Alex Henrie @ 2026-11-01 22:08 UTC (permalink / raw)
To: Xia Yan
Cc: Yingjie Wang, netdev, dsahern, idosch, davem, edumazet, kuba,
pabeni, horms, linux-kernel, yana06070
On Sat, Oct 31, 2026 at 5:44 AM Xia Yan <yanxia@cmss.chinamobile.com> wrote:
> One question on the clamp added by f4bcbf360ac8, separate from the
> wrap fixed here - I don't think this patch needs to address it. I have
> only followed the source and have not run this case.
>
> As far as I can tell the clamp's termination relies on cfg.valid_lft
> and if_public_preferred_lft being finite. Consider a public address
> with both lifetimes at INFINITY_LIFETIME and a large regen_advance,
> with no wrap involved. For example with regen_min_advance=2,
> regen_max_retry=3, dad_transmits=1, an RA Retrans Timer around
> 28,600,000 ms and HZ=1000, regen_advance is around 85802; raising
> regen_max_retry via sysctl has the same effect.
>
> If temp_prefered_lft is set below regen_advance, the effective
> max_desync_factor goes negative, desync_factor is reset to 0, and the
> clamp engages on every creation. The clamped preferred lifetime
> regen_advance + age + 1 then passes all three checks, including the
> new one. But the temporary address inherits the public address's
> tstamp, so addrconf_verify_rtnl() finds it due for regeneration one
> second after each creation: one new temporary address per second,
> each living about temp_valid_lft. Creation is only refused once age
> grows enough that regen_advance + age + 1 exceeds cfg.valid_lft,
> which here is just temp_valid_lft, so the accumulation is bounded,
> but with the numbers above it can still reach tens of thousands of
> addresses.
>
> Is this finite-lifetime assumption part of the intended behavior of
> the clamp, or would it be worth tightening separately?
Hello Xia, that is a good question. In that extreme scenario, creating
one temporary address per second is intentional. As you noted,
regen_advance is not a constant. Before I added the clamp, Linux would
just stop creating temporary addresses if regen_advance increased to a
value larger than the preferred lifetime that the user specified. No
new addresses were created until the network interface was restarted,
even if later on regen_advance dropped to below the user's preferred
lifetime. Temporary address generation was effectively disabled,
eliminating the privacy protections that the user thought that they
had enabled.
When I wrote the patch, I did not consider that the temporary
addresses might be based on a static address that has an infinite
lifetime. If having a static address causes Linux to refuse to create
more temporary addresses after a certain period of time, that's a bug.
However, I have not been able to reproduce the problem: On my machine,
with a static address, max_desync_factor=10, temp_prefered_lft=30,
regen_min_advance=60, and temp_valid_lft=90, Linux 7.2 never stops
creating new temporary addresses. Is there another combination of
parameters that might cause a problem?
-Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-11-01 22:08 ` Alex Henrie
@ 2026-11-02 7:51 ` Xia Yan
2026-11-03 16:59 ` Alex Henrie
0 siblings, 1 reply; 10+ messages in thread
From: Xia Yan @ 2026-11-02 7:51 UTC (permalink / raw)
To: Alex Henrie
Cc: Yingjie Wang, netdev, dsahern, idosch, davem, edumazet, kuba,
pabeni, horms, linux-kernel, yana06070
On 11/1/26 22:08, Alex Henrie wrote:
> Is there another combination of parameters that might cause a problem?
Hi Alex,
Thanks for explaining the reasoning behind the clamp. I was wrong
about creation eventually being refused as the public address gets
older. I had missed the "+ age" in cfg.valid_lft.
With an infinite-lifetime parent, cfg.valid_lft grows with age too.
For the values you tested, I don't see an age-dependent cutoff in
that lifetime check. Normal successful regenerations don't reach the
retry limit either: addrconf_verify_rtnl() resets the parent's
regen_count before each regeneration. Repeated ipv6_add_addr() or DAD
failures can still exhaust the retries.
I don't have a reproducer for another refusal case.
The remaining worry for me is retention. With a short preferred
lifetime and temp_valid_lft at its two-day default, deprecated
temporary addresses stay on the interface until their valid lifetime
expires, and this path does not check max_addresses. Your 90-second
configuration ages them out fast; with the default I would expect
many more addresses held at once, but I have not tested that or
measured the cost. The creation rate also depends on DAD timing, so
my earlier one-address-per-second estimate was too definite.
Thanks,
Xia
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-10-30 7:30 ` [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes Yingjie Wang
` (2 preceding siblings ...)
2026-10-31 11:44 ` Xia Yan
@ 2026-11-02 21:40 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 10+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-11-02 21:40 UTC (permalink / raw)
To: Yingjie Wang
Cc: netdev, dsahern, idosch, davem, edumazet, kuba, pabeni, horms,
alexhenrie24, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 30 Oct 2026 15:30:56 +0800 you wrote:
> ipv6_create_tempaddr() raises a temporary address's preferred lifetime to
> regen_advance + age + 1 when the configured lifetime is too short. The
> result is stored in a u32, while regen_advance and age are unsigned long.
> If the sum wraps or is truncated, the stored lifetime can still be less
> than or equal to regen_advance + age.
>
> addrconf_verify_rtnl() then sees the new address as due for regeneration
> and creates another one. Temporary addresses are not limited by
> max_addresses since commit 4b08a8f1bd8c ("ipv6: remove max_addresses
> check from ipv6_create_tempaddr"), so this can cause unbounded address
> growth. With dad_transmits set to -1, a baseline kernel reached 2859
> loopback addresses in two seconds.
>
> [...]
Here is the summary with links:
- [net,v3] ipv6: reject wrapped temporary address preferred lifetimes
https://git.kernel.org/netdev/net/c/c3e67bd82b9b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes
2026-11-02 7:51 ` Xia Yan
@ 2026-11-03 16:59 ` Alex Henrie
0 siblings, 0 replies; 10+ messages in thread
From: Alex Henrie @ 2026-11-03 16:59 UTC (permalink / raw)
To: Xia Yan
Cc: Yingjie Wang, netdev, dsahern, idosch, davem, edumazet, kuba,
pabeni, horms, linux-kernel, yana06070
On Mon, Nov 2, 2026 at 12:51 AM Xia Yan <yanxia@cmss.chinamobile.com> wrote:
> The remaining worry for me is retention. With a short preferred
> lifetime and temp_valid_lft at its two-day default, deprecated
> temporary addresses stay on the interface until their valid lifetime
> expires, and this path does not check max_addresses. Your 90-second
> configuration ages them out fast; with the default I would expect
> many more addresses held at once, but I have not tested that or
> measured the cost. The creation rate also depends on DAD timing, so
> my earlier one-address-per-second estimate was too definite.
With the default temp_valid_lft of 2 days, creating 1 temporary
address per second would result in a maximum of 172,800 temporary
addresses. If the user explicitly sets temp_prefered_lft=1,
regen_min_advance=0, and dad_transmits=0, that's exactly what should
happen. When I tested that scenario on my desktop computer today,
Firefox worked and overall system stability was fine, but Chromium
failed to load any pages and NetworkManager became unresponsive. It
seems that some software doesn't mind that there are tens of thousands
of IPv6 addresses and other software won't tolerate it.
I'm not convinced that using max_addresses to limit the number of
temporary addresses is a good idea. The default value of max_addresses
is 16, so in the worst-case scenario, after 16 seconds temporary
address creation would be effectively disabled until the addresses
expire 2 days later. Similarly, if the user sets temp_prefered_lft to
1 hour (a perfectly reasonable value), the limit would be silently
reached after 16 hours. If we increase max_addresses to 48 to be sure
that 1 temporary address per hour can be created for 2 days, a brief
period of worst-case router advertisements would still use up all of
the addresses in 48 seconds. To protect the user's privacy, new
temporary addresses must continue to be created no matter what is
happening on the network. (With one exception: If the SLAAC address's
lifetime is so short that it's effectively a temporary address
already.)
We already have regen_min_advance which specifies the lower limit of
regen_advance. Maybe we should also have a regen_max_advance to
specify an upper limit. That way, a misconfigured router could not
cause a Linux client to create a new temporary address long before the
current temporary address expires, nor could a misconfigured router
cause Linux to use a long-lived SLAAC address without creating any
temporary addresses at all. The maximum number of simultaneous
temporary addresses would become temp_valid_lft / (temp_prefered_lft -
max_desync_factor - regen_max_advance), and the user would be expected
to set temp_prefered_lft to a value larger than max_desync_factor +
regen_max_advance. With temp_valid_lft=172800 (2 days),
temp_prefered_lft=3600 (1 hour), max_desync_factor=600 (10 minutes),
and regen_max_advance=300 (5 minutes), there would be a maximum of 64
temporary addresses at any given time.
-Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-11-03 17:00 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_C2E4FE9B7C0A05615861782611715EAA9C0A@qq.com>
2026-10-30 7:30 ` [PATCH net v3] ipv6: reject wrapped temporary address preferred lifetimes Yingjie Wang
2026-10-30 7:33 ` netdev-bot+sinfo
2026-10-30 13:43 ` Ido Schimmel
2026-10-31 17:22 ` Alex Henrie
2026-10-31 11:44 ` Xia Yan
2026-10-31 18:36 ` Yingjie Wang
2026-11-01 22:08 ` Alex Henrie
2026-11-02 7:51 ` Xia Yan
2026-11-03 16:59 ` Alex Henrie
2026-11-02 21:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®