* [PATCH] LoongArch: Kconfig: Fix help text of CMDLINE_EXTEND
@ 2025-03-28 10:12 Yeking
2025-03-29 8:28 ` Huacai Chen
0 siblings, 1 reply; 4+ messages in thread
From: Yeking @ 2025-03-28 10:12 UTC (permalink / raw)
To: loongarch
Cc: 谢致邦 (XIE Zhibang),
Huacai Chen, WANG Xuerui, Guo Ren, Jiaxun Yang, linux-kernel
From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
It is the built-in command line appended to the bootloader command line,
not the bootloader command line appended to the built-in command line.
Fixes: fa96b57c1490 ("LoongArch: Add build infrastructure")
Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
---
arch/loongarch/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index 7477d5f8d876..067c0b994648 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -388,8 +388,8 @@ config CMDLINE_BOOTLOADER
config CMDLINE_EXTEND
bool "Use built-in to extend bootloader kernel arguments"
help
- The command-line arguments provided during boot will be
- appended to the built-in command line. This is useful in
+ The built-in command line will be appended to the command-
+ line arguments provided during boot. This is useful in
cases where the provided arguments are insufficient and
you don't want to or cannot modify them.
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] LoongArch: Kconfig: Fix help text of CMDLINE_EXTEND
2025-03-28 10:12 [PATCH] LoongArch: Kconfig: Fix help text of CMDLINE_EXTEND Yeking
@ 2025-03-29 8:28 ` Huacai Chen
2025-03-29 9:44 ` 谢致邦 (XIE Zhibang)
0 siblings, 1 reply; 4+ messages in thread
From: Huacai Chen @ 2025-03-29 8:28 UTC (permalink / raw)
To: Yeking; +Cc: loongarch, WANG Xuerui, Guo Ren, Jiaxun Yang, linux-kernel
Hi, Zhibang,
On Fri, Mar 28, 2025 at 6:13 PM <Yeking@red54.com> wrote:
>
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
>
> It is the built-in command line appended to the bootloader command line,
> not the bootloader command line appended to the built-in command line.
>
> Fixes: fa96b57c1490 ("LoongArch: Add build infrastructure")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> ---
> arch/loongarch/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 7477d5f8d876..067c0b994648 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -388,8 +388,8 @@ config CMDLINE_BOOTLOADER
> config CMDLINE_EXTEND
> bool "Use built-in to extend bootloader kernel arguments"
> help
> - The command-line arguments provided during boot will be
> - appended to the built-in command line. This is useful in
> + The built-in command line will be appended to the command-
> + line arguments provided during boot. This is useful in
> cases where the provided arguments are insufficient and
How about replace "to the built-in command line" with "with the
built-in command line" and keep others unchanged?
Huacai
> you don't want to or cannot modify them.
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] LoongArch: Kconfig: Fix help text of CMDLINE_EXTEND
2025-03-29 8:28 ` Huacai Chen
@ 2025-03-29 9:44 ` 谢致邦 (XIE Zhibang)
2025-03-30 8:40 ` Huacai Chen
0 siblings, 1 reply; 4+ messages in thread
From: 谢致邦 (XIE Zhibang) @ 2025-03-29 9:44 UTC (permalink / raw)
To: chenhuacai; +Cc: Yeking, guoren, jiaxun.yang, kernel, linux-kernel, loongarch
Hi, Huacai,
> How about replace "to the built-in command line" with "with the
> built-in command line" and keep others unchanged?
It seems that the use of the preposition "with" does not conform to the regular
collocation of "append" and may lead to ambiguity.
You can consult an LLM such as DeepSeek, Qwen, or ChatGPT.
Zhibang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] LoongArch: Kconfig: Fix help text of CMDLINE_EXTEND
2025-03-29 9:44 ` 谢致邦 (XIE Zhibang)
@ 2025-03-30 8:40 ` Huacai Chen
0 siblings, 0 replies; 4+ messages in thread
From: Huacai Chen @ 2025-03-30 8:40 UTC (permalink / raw)
To: 谢致邦 (XIE Zhibang)
Cc: guoren, jiaxun.yang, kernel, linux-kernel, loongarch
On Sat, Mar 29, 2025 at 5:45 PM 谢致邦 (XIE Zhibang) <Yeking@red54.com> wrote:
>
> Hi, Huacai,
>
> > How about replace "to the built-in command line" with "with the
> > built-in command line" and keep others unchanged?
> It seems that the use of the preposition "with" does not conform to the regular
> collocation of "append" and may lead to ambiguity.
> You can consult an LLM such as DeepSeek, Qwen, or ChatGPT.
OK, I applied but change the title to "LoongArch: Fix help text of
CMDLINE_EXTEND in Kconfig", thanks.
Huacai
>
> Zhibang
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-30 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-28 10:12 [PATCH] LoongArch: Kconfig: Fix help text of CMDLINE_EXTEND Yeking
2025-03-29 8:28 ` Huacai Chen
2025-03-29 9:44 ` 谢致邦 (XIE Zhibang)
2025-03-30 8:40 ` Huacai Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®