From: fujunjie <fujunjie1@qq.com>
To: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Alexandre Ghiti <alexghiti@meta.com>,
Kairui Song <kasong@tencent.com>,
Usama Arif <usamaarif642@gmail.com>
Cc: Chris Li <chrisl@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Yosry Ahmed <yosry@kernel.org>, Nhat Pham <nphamcs@gmail.com>,
David Hildenbrand <david@kernel.org>,
Hugh Dickins <hughd@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: [RFC PATCH v2 7/9] mm/shmem: provide VMA-hint locality for zswap large swapin
Date: Fri, 29 May 2026 12:19:26 +0000 [thread overview]
Message-ID: <tencent_A2335C92CF3C8A7EF3121E4A23D437531608@qq.com> (raw)
In-Reply-To: <tencent_98CD9F78E48D08DC005A6471A13CFF28B60A@qq.com>
Let the shmem swap fault path pass locality evidence into the common
zswap large-swapin policy. Shmem does not have anon PTE-young density
evidence, so this first step only treats explicit VM_SEQ_READ as
positive evidence and VM_RAND_READ as a veto.
The non-fault shmem readahead path remains unchanged. This keeps large
zswap swapin limited to synchronous shmem faults where the caller
supplies a VMA and the common policy can still fall back to order-0.
Signed-off-by: fujunjie <fujunjie1@qq.com>
---
mm/shmem.c | 42 +++++++++++++++++++++++++++++++++++++-----
1 file changed, 37 insertions(+), 5 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index fa99b48ed62b..a5ac35ac85fb 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -30,6 +30,7 @@
#include <linux/fileattr.h>
#include <linux/filelock.h>
#include <linux/mm.h>
+#include <linux/memcontrol.h>
#include <linux/random.h>
#include <linux/sched/signal.h>
#include <linux/export.h>
@@ -1791,6 +1792,29 @@ static struct folio *shmem_swapin_cluster(swp_entry_t swap, gfp_t gfp,
return folio;
}
+static unsigned long shmem_swapin_locality_orders(struct vm_fault *vmf,
+ unsigned long orders)
+{
+ struct vm_area_struct *vma = vmf ? vmf->vma : NULL;
+ unsigned long candidates = orders & ~BIT(0);
+
+ /*
+ * Shmem does not have anon-style PTE young density evidence. Start with
+ * explicit VMA access hints; future shmem/page-cache readahead evidence
+ * can be folded into this producer without changing common swapin policy.
+ */
+ if (!vma)
+ return 0;
+
+ if (vma->vm_flags & VM_RAND_READ)
+ return 0;
+
+ if (vma->vm_flags & VM_SEQ_READ)
+ return candidates;
+
+ return 0;
+}
+
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
bool shmem_hpage_pmd_enabled(void)
{
@@ -2020,18 +2044,22 @@ static struct folio *shmem_swap_alloc_folio(struct inode *inode,
struct vm_fault *vmf, pgoff_t index,
swp_entry_t entry, int order, gfp_t gfp)
{
+ unsigned long locality_orders;
+ unsigned long orders;
pgoff_t ilx;
struct folio *folio;
struct mempolicy *mpol;
struct shmem_inode_info *info = SHMEM_I(inode);
- if ((vmf && unlikely(userfaultfd_armed(vmf->vma))) ||
- !zswap_never_enabled())
+ if (vmf && unlikely(userfaultfd_armed(vmf->vma)))
order = 0;
again:
+ orders = BIT(order);
+ locality_orders = shmem_swapin_locality_orders(vmf, orders);
mpol = shmem_get_pgoff_policy(info, index, order, &ilx);
- folio = swapin_sync(entry, gfp, BIT(order), 0, vmf, mpol, ilx);
+ folio = swapin_sync(entry, gfp, orders, locality_orders, vmf, mpol,
+ ilx);
mpol_cond_put(mpol);
if (!IS_ERR(folio))
@@ -2339,7 +2367,7 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index,
if (!folio_matches_swap_entry(folio, swap) ||
shmem_confirm_swap(mapping, index, swap) < 0) {
error = -EEXIST;
- goto unlock;
+ goto failed_swapcache;
}
if (!folio_test_uptodate(folio)) {
error = -EIO;
@@ -2369,6 +2397,8 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index,
if (sgp == SGP_WRITE)
folio_mark_accessed(folio);
+ if (folio_test_large(folio))
+ memcg1_swapin(folio);
folio_put_swap(folio, NULL);
swap_cache_del_folio(folio);
folio_mark_dirty(folio);
@@ -2379,9 +2409,11 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index,
failed:
if (shmem_confirm_swap(mapping, index, swap) < 0)
error = -EEXIST;
+failed_swapcache:
+ if (folio && folio_test_large(folio) && folio_test_swapcache(folio))
+ memcg1_swapin(folio);
if (error == -EIO)
shmem_set_folio_swapin_error(inode, index, folio, swap);
-unlock:
if (folio)
folio_unlock(folio);
failed_nolock:
--
2.34.1
next prev parent reply other threads:[~2026-05-29 12:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 12:17 [RFC PATCH v2 0/9] mm: support zswap-backed large folio swapin fujunjie
2026-05-29 12:19 ` [RFC PATCH v2 1/9] mm/zswap: expose range state for swapin policy fujunjie
2026-05-29 18:35 ` Nhat Pham
2026-05-31 13:47 ` Fujunjie
2026-05-29 12:19 ` [RFC PATCH v2 2/9] mm: let swap_read_folio() report retryable zswap races fujunjie
2026-05-29 12:19 ` [RFC PATCH v2 3/9] mm/zswap: support fully zswap-backed large folio loads fujunjie
2026-05-29 18:25 ` Nhat Pham
2026-05-31 20:03 ` Fujunjie
2026-05-29 12:19 ` [RFC PATCH v2 4/9] mm: admit large swapin by backend range in swapin_sync() fujunjie
2026-05-29 14:43 ` Kairui Song
2026-05-29 14:45 ` Kairui Song
2026-05-31 12:34 ` Fujunjie
2026-05-31 12:21 ` Fujunjie
2026-05-29 18:34 ` Nhat Pham
2026-05-31 13:15 ` Fujunjie
2026-05-29 12:19 ` [RFC PATCH v2 5/9] mm: add common locality admission for zswap large swapin fujunjie
2026-05-29 19:00 ` Nhat Pham
2026-06-01 9:47 ` Fujunjie
2026-05-29 12:19 ` [RFC PATCH v2 6/9] mm: provide anon locality evidence " fujunjie
2026-05-29 19:22 ` Nhat Pham
2026-05-31 13:11 ` Fujunjie
2026-05-29 12:19 ` fujunjie [this message]
2026-05-29 12:19 ` [RFC PATCH v2 8/9] mm: try all-zswap large swapin within swap readahead windows fujunjie
2026-05-29 12:19 ` [RFC PATCH v2 9/9] docs: mm: update THP swapin counter descriptions fujunjie
2026-05-29 18:37 ` Nhat Pham
2026-05-31 13:21 ` Fujunjie
2026-05-29 18:06 ` [RFC PATCH v2 0/9] mm: support zswap-backed large folio swapin Nhat Pham
2026-05-31 12:32 ` Fujunjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_A2335C92CF3C8A7EF3121E4A23D437531608@qq.com \
--to=fujunjie1@qq.com \
--cc=akpm@linux-foundation.org \
--cc=alexghiti@meta.com \
--cc=cgroups@vger.kernel.org \
--cc=chrisl@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®