From: "Ziyou Wang (Lenovo)" <ziyou.dev@foxmail.com>
To: lukas@wunner.de
Cc: helgaas@kernel.org, bhelgaas@google.com,
sathyanarayanan.kuppuswamy@linux.intel.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] PCI/DPC: Increase recovery timeout to 60 seconds
Date: Fri, 20 Nov 2026 11:22:09 +0800 [thread overview]
Message-ID: <tencent_BA4D887B4358C473171507488D60E3F66205@qq.com> (raw)
In-Reply-To: <av666Q38S0q5HqYS@wunner.de>
Hi Lukas,
The ACS Violation in that log is not organic, it is injected on purpose.
The platform is AMD and we use AMD's RAS Error Injection Test tool to
inject an "ACS fatal" error at the Root Port. The test steps are:
1. Shorten the machine check polling interval:
echo 1 > /sys/devices/system/machinecheck/machinecheck0/check_interval
2. List the PCIe slot info to find the socket/die/NBIO, PCIe core and
port that the NVMe drive is attached to:
./cmdline_amdraserrorinjectiontest --listpcieslotinfo
3. Start I/O traffic on the NVMe drive:
dd if=/dev/nvmeXnY of=/dev/null bs=64k status=progress conv=noerror,sync
4. Inject the ACS fatal error at that Root Port:
./cmdline_amdraserrorinjectiontest --pcieerror \
--sockdienbio <socket:die:nbio> --errortype 4 \
--pciecore <core> --pcieport <port> --enablestatusregisterpolling 1
This raises ACSViol in the Root Port's AER Uncorrectable Error Status.
The BIOS has AER and ACS enabled and AER reporting is set to firmware
first, so firmware signals the EDR event and DPC containment follows.
The TLP you decoded is a regular in-flight DMA write from the NVMe drive
that happened to be captured in the AER Header Log (there was read
traffic on the drive at injection time). Its Requester ID is valid and
Source Validation is enabled, so nothing in it violates any ACS rule.
The ACSViol comes from the injector, not from real ACS logic.
The ACS settings on the Root Port (same platform, 1022:1108):
ACSCap: SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+ UpstreamFwd+ EgressCtrl- DirectTrans+
ACSCtl: SrcValid+ TransBlk- ReqRedir+ CmpltRedir+ UpstreamFwd+ EgressCtrl- DirectTrans-
The goal of the test was to produce a DPC containment event on an NVMe
device that needs about 4 seconds to become config-ready again, in order
to exercise the recovery path.
Thanks,
Ziyou
prev parent reply other threads:[~2026-11-20 3:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261106082612.1840817-1-ziyou.dev@foxmail.com>
2026-11-06 8:56 ` Ziyou Wang (Lenovo)
2026-11-06 15:21 ` Bjorn Helgaas
2026-11-19 3:30 ` Ziyou Wang (Lenovo)
2026-11-19 9:01 ` Lukas Wunner
2026-11-20 3:22 ` Ziyou Wang (Lenovo) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_BA4D887B4358C473171507488D60E3F66205@qq.com \
--to=ziyou.dev@foxmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®