* [PATCH v2] drm/rockchip: dsi: enable RK3506 PHY data lanes in GRF
@ 2026-11-21 17:10 ZhuXiangyu
0 siblings, 0 replies; only message in thread
From: ZhuXiangyu @ 2026-11-21 17:10 UTC (permalink / raw)
To: Sandy Huang, Heiko Stuebner
Cc: Andy Yan, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-arm-kernel,
linux-rockchip, linux-kernel, ZhuXiangyu
rk3506_chip_data currently only clears the turnaround, force-rx, and
force-tx-stop fields in RK3506_SYS_GRF_SOC_CON6. As a result, the DSI
PHY data lanes remain disabled unless the bootloader happens to enable
them.
Set RK3506_DSI_PHY_ENABLE_LANE0 and RK3506_DSI_PHY_ENABLE_LANE1 in
lanecfg1 so the data lanes are reliably enabled by the driver.
Tested on an RK3506B board: the panel receives the low-power init
sequence and the framebuffer console displays properly.
Fixes: cabeacc7eadc ("drm/rockchip: dsi: Add support for rk3506")
Signed-off-by: Xiangyu Zhu <1194781887@qq.com>
---
Changes in v2:
- Split out from the combined drm/phy patch into a standalone drm
subsystem patch per Heiko's review.
- Limit recipients to drm and Rockchip maintainers/lists.
- Fix Signed-off-by author name formatting.
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 30d6f83c..116cc140 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -199,6 +199,8 @@
#define RK3506_SYS_GRF_SOC_CON6 0x0018
#define RK3506_DSI_FORCETXSTOPMODE (0xf << 4)
+#define RK3506_DSI_PHY_ENABLE_LANE1 BIT(9)
+#define RK3506_DSI_PHY_ENABLE_LANE0 BIT(8)
#define RK3506_DSI_TURNDISABLE BIT(2)
#define RK3506_DSI_FORCERXMODE BIT(0)
@@ -1727,7 +1729,9 @@ static const struct rockchip_dw_dsi_chip_data rk3506_chip_data[] = {
.lanecfg1_grf_reg = RK3506_SYS_GRF_SOC_CON6,
.lanecfg1 = (FIELD_PREP_WM16_CONST(RK3506_DSI_TURNDISABLE, 0) |
FIELD_PREP_WM16_CONST(RK3506_DSI_FORCERXMODE, 0) |
- FIELD_PREP_WM16_CONST(RK3506_DSI_FORCETXSTOPMODE, 0)),
+ FIELD_PREP_WM16_CONST(RK3506_DSI_FORCETXSTOPMODE, 0) |
+ FIELD_PREP_WM16_CONST(RK3506_DSI_PHY_ENABLE_LANE0, 1) |
+ FIELD_PREP_WM16_CONST(RK3506_DSI_PHY_ENABLE_LANE1, 1)),
.max_data_lanes = 2,
.max_bit_rate_per_lane = 1500000000UL,
.dphy_get_timing = dw_mipi_dsi_phy_px30_get_timing,
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-21 17:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 17:10 [PATCH v2] drm/rockchip: dsi: enable RK3506 PHY data lanes in GRF ZhuXiangyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®