mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: MingTao Huang <1037827920@qq.com>
To: Dave Chinner <dgc@kernel.org>
Cc: Carlos Maiolino <cem@kernel.org>,
	Chandan Babu R <chandanbabu@kernel.org>,
	"Darrick J . Wong" <djwong@kernel.org>,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	MingTao Huang <mintaohuang@tencent.com>,
	MingTao Huang <1037827920@qq.com>
Subject: Re: [PATCH] xfs: fix skipped flushing items not counted in xfsaild_push()
Date: Thu, 24 Sep 2026 10:11:26 +0800	[thread overview]
Message-ID: <tencent_C716F404D30EB56D3E69D2B29D4D9AD78307@qq.com> (raw)
In-Reply-To: <arL9Xrmf5Q7wd3T4@dread>

Hi Dave,

Thank you for the detailed explanation.

> As the author of this code, I can say for certain that the
> intent of 'count' is to count the number of items we made
> pushing decisions about, not count the number of items we
> have iterated.

I wasn't aware that count tracks push decisions rather than
items visited. Thank you for clarifying this.

> Tell me how the delwri list got so long that it gets stuck
> inside xfs_buf_delwri_submit_nowait(). Whatever caused that
> is the bug that we need to understand and fix

I think your point is well taken. I will continue investigating
the root cause of this soft lockup and follow up when I have
more evidence.

Thanks,
MingTao


      parent reply	other threads:[~2026-09-24  2:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  8:14 MingTao Huang
2026-09-22 15:02 ` Darrick J. Wong
2026-09-22 22:12 ` Dave Chinner
2026-09-23 13:44   ` Brian Foster
2026-09-24  0:34     ` Dave Chinner
2026-09-24  2:11   ` MingTao Huang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_C716F404D30EB56D3E69D2B29D4D9AD78307@qq.com \
    --to=1037827920@qq.com \
    --cc=cem@kernel.org \
    --cc=chandanbabu@kernel.org \
    --cc=dgc@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mintaohuang@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®