mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Congjie Zhou" <zcjie0802@qq.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
	jasowangio <jasowangio@gmail.com>, eperezma <eperezma@redhat.com>,
	xuanzhuo <xuanzhuo@linux.alibaba.com>,
	andrew+netdev <andrew+netdev@lunn.ch>,
	davem <davem@davemloft.net>, edumazet <edumazet@kernel.org>,
	kuba <kuba@kernel.org>, pabeni <pabeni@redhat.com>,
	horms <horms@kernel.org>,
	virtualization <virtualization@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] virtio_net: RX stall caused by masking callbacks after NAPI ownership release
Date: Tue, 17 Nov 2026 00:05:24 +0800	[thread overview]
Message-ID: <tencent_D0650F8CA2AAE4C258BFE5BCE805CDB4CA0A@qq.com> (raw)
In-Reply-To: <20261116044750-mutt-send-email-mst@kernel.org>

> Maybe let's just check the poll list.

Checking the poll list fixes the earlier race where the watchdog has
already finished. However, the timer can still be consumed without
triggering another poll if it fires after the old caller's check:

  old poll / watchdog                successor busy-poll
  -------------------                -------------------
  napi_complete_done():
    clear SCHED, arm timer,
    return false
                                     acquire NAPI
                                     enable callbacks,
                                     then pause before completion
  disable callbacks
  napi_has_pending_poll():
    timer is still queued,
    so skip napi_schedule()
  old poll exits
  watchdog expires, sees SCHED=1:
    no scheduling, no MISSED
  watchdog returns
                                     napi_complete_done(..., 0):
                                       clear SCHED, return true
                                     queue is empty, exit

At that point, the next used entry ends up with neither notifications
enabled nor a pending timer or scheduled poll to process it.

Stepping back, the fundamental ordering issue here is:

  old releases SCHED
    -> successor rearms callbacks
    -> old masks callbacks

Right now, nothing guarantees that the old mask happens before the
successor's rearm. Even if the successor still holds SCHED, it might
have already done its final rearm. Similarly, having a queued timer
doesn't guarantee another poll—the watchdog will simply bail out without
scheduling because SCHED is already set. So all these state checks can
look completely valid at the time, yet still fail to guarantee recovery.

The root cause is that with the timer introduced by NAPI defer,
napi_complete_done() can return false while still giving up SCHED
ownership, leaving us with nothing else to synchronize the callback
state. Before NAPI defer, returning false meant we still held onto
SCHED, so everything worked as expected.

To fix this properly, I think we either need to call
virtqueue_disable_cb() before giving up SCHED ownership, or introduce a
separate synchronization mechanism (like a lock) to ensure we can always
recover NAPI execution. Simple flag checks alone don't seem enough to
close this race completely.

  reply	other threads:[~2026-11-16 16:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 13:36 Congjie Zhou
2026-11-11 13:50 ` [PATCH net 1/2] net: napi: add completion with an ordered IRQ mask callback Congjie Zhou
2026-11-11 13:56   ` netdev-bot+sinfo
2026-11-11 15:08     ` zcj
2026-11-11 13:50 ` [PATCH net 2/2] virtio_net: mask callbacks before releasing NAPI ownership Congjie Zhou
2026-11-15  7:12 ` [PATCH net v2 1/2] net: napi: add completion with an ordered IRQ mask callback Congjie Zhou
2026-11-15 18:26   ` Jakub Kicinski
2026-11-15  7:12 ` [PATCH net v2 2/2] virtio_net: mask callbacks before releasing NAPI ownership Congjie Zhou
2026-11-15 20:09 ` [BUG] virtio_net: RX stall caused by masking callbacks after NAPI ownership release Michael S. Tsirkin
2026-11-15 23:07 ` Michael S. Tsirkin
2026-11-16  8:47   ` Congjie Zhou
2026-11-16  9:52     ` Michael S. Tsirkin
2026-11-16 16:05       ` Congjie Zhou [this message]
2026-11-19 11:50         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_D0650F8CA2AAE4C258BFE5BCE805CDB4CA0A@qq.com \
    --to=zcjie0802@qq.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=horms@kernel.org \
    --cc=jasowangio@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®