[PATCH] thermal: rcar-thermal: fix runtime PM cleanup

[PATCH] thermal: rcar-thermal: fix runtime PM cleanup

[Jiawen Liu]

Update rcar_thermal_probe() for the confirmed driver lifecycle defect.

Keep the change limited to the concrete operation shown in the final
patch.

Signed-off-by: jiawen <1298662399@qq.com>
---
diff --git a/drivers/thermal/renesas/rcar_thermal.c b/drivers/thermal/renesas/rcar_thermal.c
--- a/drivers/thermal/renesas/rcar_thermal.c
+++ b/drivers/thermal/renesas/rcar_thermal.c
@@ -414,7 +414,12 @@
 	common->dev = dev;
 
 	pm_runtime_enable(dev);
-	pm_runtime_get_sync(dev);
+	ret = pm_runtime_get_sync(dev);
+	if (ret < 0) {
+		pm_runtime_put_noidle(dev);
+		pm_runtime_disable(dev);
+		return ret;
+	}
 
 	for (i = 0; i < chip->nirqs; i++) {
 		int irq;

Re: [PATCH] thermal: rcar-thermal: fix runtime PM cleanup

[Geert Uytterhoeven]

Hi Jiawen,

Thanks for your patch!

On Tue, 18 Aug 2026 at 15:16, Jiawen Liu <1298662399@qq.com> wrote:
> Update rcar_thermal_probe() for the confirmed driver lifecycle defect.
>
> Keep the change limited to the concrete operation shown in the final
> patch.

Please write a better patch description.

>
> Signed-off-by: jiawen <1298662399@qq.com>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] thermal: rcar-thermal: fix runtime PM cleanup

[Jiawen Liu]

Hi Geert,

Thanks for the feedback. The description did not explain the failure path.

The probe path ignores a failure from pm_runtime_get_sync() and continues
initialization. If it returns at that point, the usage count increment from
pm_runtime_get_sync() and the enabled runtime PM state both need to be
balanced.

I'll recheck the unwind against the current driver and describe the affected
path and cleanup explicitly.

Thanks,
Jiawen