* [PATCH v2] dt-bindings: media: i2c: dongwoon,dw9768: add Giantec GT9764
@ 2026-10-13 4:37 Mingxuan Guo
2026-10-13 9:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Mingxuan Guo @ 2026-10-13 4:37 UTC (permalink / raw)
To: Sakari Ailus, Mauro Carvalho Chehab
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-media, linux-kernel, Mingxuan Guo
The GT9764 is one of Giantec's VCM driver parts and shares the register
model of the GT9769 already covered by this binding: the vendor's VCM
driver application note (AN971) covers GT9764, GT9767, GT9768, GT9769,
GT9772 and GT9778, all built around the same 10-bit DAC with the AAC
actuator-control extensions.
Document it as a specific compatible that requires the GT9769 as its
fallback, so the existing driver binds through the GT9769 entry and no
driver change is needed.
Signed-off-by: Mingxuan Guo <gmx472@qq.com>
---
Changes in v2:
- Use the GT9769 as a fallback compatible instead of a standalone driver
entry (Conor Dooley), and drop the driver patch accordingly; this also
clears the Media CI warning about the compatible being undocumented.
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
--- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
@@ -20,9 +20,13 @@ description: |-
properties:
compatible:
- enum:
- - dongwoon,dw9768 # for DW9768 VCM
- - giantec,gt9769 # for GT9769 VCM
+ oneOf:
+ - enum:
+ - dongwoon,dw9768 # for DW9768 VCM
+ - giantec,gt9769 # for GT9769 VCM
+ - items:
+ - const: giantec,gt9764 # for GT9764 VCM
+ - const: giantec,gt9769 # fallback, same register model
reg:
maxItems: 1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dt-bindings: media: i2c: dongwoon,dw9768: add Giantec GT9764
2026-10-13 4:37 [PATCH v2] dt-bindings: media: i2c: dongwoon,dw9768: add Giantec GT9764 Mingxuan Guo
@ 2026-10-13 9:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-13 9:40 UTC (permalink / raw)
To: Mingxuan Guo
Cc: Sakari Ailus, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree, linux-media,
linux-kernel
On Tue, Oct 13, 2026 at 12:37:01PM +0800, Mingxuan Guo wrote:
> The GT9764 is one of Giantec's VCM driver parts and shares the register
> model of the GT9769 already covered by this binding: the vendor's VCM
> driver application note (AN971) covers GT9764, GT9767, GT9768, GT9769,
> GT9772 and GT9778, all built around the same 10-bit DAC with the AAC
> actuator-control extensions.
>
> Document it as a specific compatible that requires the GT9769 as its
> fallback, so the existing driver binds through the GT9769 entry and no
> driver change is needed.
>
> Signed-off-by: Mingxuan Guo <gmx472@qq.com>
> ---
> Changes in v2:
> - Use the GT9769 as a fallback compatible instead of a standalone driver
> entry (Conor Dooley), and drop the driver patch accordingly; this also
> clears the Media CI warning about the compatible being undocumented.
>
> Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
> --- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
> @@ -20,9 +20,13 @@ description: |-
>
> properties:
> compatible:
> - enum:
> - - dongwoon,dw9768 # for DW9768 VCM
> - - giantec,gt9769 # for GT9769 VCM
> + oneOf:
> + - enum:
> + - dongwoon,dw9768 # for DW9768 VCM
> + - giantec,gt9769 # for GT9769 VCM
> + - items:
> + - const: giantec,gt9764 # for GT9764 VCM
> + - const: giantec,gt9769 # fallback, same register model
Drop comments, they duplicate compatible and as you can see, the
existing comments confuse people into thinking adding more duplicated
information is a positive thing.
Without comments:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-13 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-13 4:37 [PATCH v2] dt-bindings: media: i2c: dongwoon,dw9768: add Giantec GT9764 Mingxuan Guo
2026-10-13 9:40 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®