From: tip-bot for Josh Poimboeuf <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jslaby@suse.cz,
peterz@infradead.org, jgross@suse.com,
boris.ostrovsky@oracle.com, jpoimboe@redhat.com, hpa@zytor.com,
torvalds@linux-foundation.org, tglx@linutronix.de,
mingo@kernel.org, luto@kernel.org
Subject: [tip:core/objtool] objtool: Don't report end of section error after an empty unwind hint
Date: Thu, 28 Sep 2017 03:54:56 -0700 [thread overview]
Message-ID: <tip-00d96180dc38ef872ac471c2d3e14b067cbd895d@git.kernel.org> (raw)
In-Reply-To: <ddafe199dd8797e40e3c2777373347eba1d65572.1505764066.git.jpoimboe@redhat.com>
Commit-ID: 00d96180dc38ef872ac471c2d3e14b067cbd895d
Gitweb: https://git.kernel.org/tip/00d96180dc38ef872ac471c2d3e14b067cbd895d
Author: Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Mon, 18 Sep 2017 21:43:30 -0500
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 28 Sep 2017 09:39:02 +0200
objtool: Don't report end of section error after an empty unwind hint
If asm code specifies an UNWIND_HINT_EMPTY hint, don't warn if the
section ends unexpectedly. This can happen with the xen-head.S code
because the hypercall_page is "text" but it's all zeros.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Juergen Gross <jgross@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/ddafe199dd8797e40e3c2777373347eba1d65572.1505764066.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/check.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index a0c518e..83f370f 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1752,11 +1752,14 @@ static int validate_branch(struct objtool_file *file, struct instruction *first,
if (insn->dead_end)
return 0;
- insn = next_insn;
- if (!insn) {
+ if (!next_insn) {
+ if (state.cfa.base == CFI_UNDEFINED)
+ return 0;
WARN("%s: unexpected end of section", sec->name);
return 1;
}
+
+ insn = next_insn;
}
return 0;
next prev parent reply other threads:[~2017-09-28 10:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 2:43 [PATCH v2 0/8] x86/asm: Add unwind hint annotations to head code Josh Poimboeuf
2017-09-19 2:43 ` [PATCH v2 1/8] objtool: Don't report end of section error after an empty unwind hint Josh Poimboeuf
2017-09-28 10:54 ` tip-bot for Josh Poimboeuf [this message]
2017-09-19 2:43 ` [PATCH v2 2/8] x86/head: Remove confusing comment Josh Poimboeuf
2017-09-28 10:55 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
2017-09-19 2:43 ` [PATCH v2 3/8] x86/head: Remove unused 'bad_address' code Josh Poimboeuf
2017-09-28 10:55 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
2017-09-19 2:43 ` [PATCH v2 4/8] x86/head: Fix head ELF function annotations Josh Poimboeuf
2017-09-28 10:56 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
2017-09-19 2:43 ` [PATCH v2 5/8] x86/boot: Annotate verify_cpu() as a callable function Josh Poimboeuf
2017-09-28 10:56 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
2017-09-19 2:43 ` [PATCH v2 6/8] x86/xen: Fix xen head ELF annotations Josh Poimboeuf
2017-09-28 10:56 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
2017-09-19 2:43 ` [PATCH v2 7/8] x86/xen: Add unwind hint annotations Josh Poimboeuf
2017-09-28 10:57 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
2017-09-19 2:43 ` [PATCH v2 8/8] x86/head: " Josh Poimboeuf
2017-09-28 10:57 ` [tip:core/objtool] " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-00d96180dc38ef872ac471c2d3e14b067cbd895d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome