From: tip-bot for Yunlong Song <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, mingo@kernel.org, wangnan0@huawei.com,
paulus@samba.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, acme@redhat.com,
a.p.zijlstra@chello.nl, yunlong.song@huawei.com
Subject: [tip:perf/core] perf tools: Add the bash completion for listing subsubcommands of perf data
Date: Sun, 22 Mar 2015 03:11:01 -0700 [thread overview]
Message-ID: <tip-01b7160bc6674912f6b7043bbf58d66e62e41054@git.kernel.org> (raw)
In-Reply-To: <1426685758-25488-8-git-send-email-yunlong.song@huawei.com>
Commit-ID: 01b7160bc6674912f6b7043bbf58d66e62e41054
Gitweb: http://git.kernel.org/tip/01b7160bc6674912f6b7043bbf58d66e62e41054
Author: Yunlong Song <yunlong.song@huawei.com>
AuthorDate: Wed, 18 Mar 2015 21:35:52 +0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 19 Mar 2015 13:49:38 -0300
perf tools: Add the bash completion for listing subsubcommands of perf data
The bash completion does not support listing subsubcommands for 'perf
data <TAB>', so fix it.
Example:
Before this patch:
$ perf data <TAB>
$
As shown above, the subsubcommands of perf data does not come out.
After this patch:
$ perf data <TAB>
convert
As shown above, the subsubcommands of perf data can come out now.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1426685758-25488-8-git-send-email-yunlong.song@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-data.c | 6 ++++--
tools/perf/perf-completion.sh | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-data.c b/tools/perf/builtin-data.c
index 155cf75..709152a 100644
--- a/tools/perf/builtin-data.c
+++ b/tools/perf/builtin-data.c
@@ -22,7 +22,9 @@ static const struct option data_options[] = {
OPT_END()
};
-static const char * const data_usage[] = {
+static const char * const data_subcommands[] = { "convert", NULL };
+
+static const char *data_usage[] = {
"perf data [<common options>] <command> [<options>]",
NULL
};
@@ -98,7 +100,7 @@ int cmd_data(int argc, const char **argv, const char *prefix)
if (argc < 2)
goto usage;
- argc = parse_options(argc, argv, data_options, data_usage,
+ argc = parse_options_subcommand(argc, argv, data_options, data_subcommands, data_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
if (argc < 1)
goto usage;
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index 7b98ae4..535ff72 100644
--- a/tools/perf/perf-completion.sh
+++ b/tools/perf/perf-completion.sh
@@ -143,7 +143,7 @@ __perf_main ()
__perfcomp_colon "$evts" "$cur"
else
# List subcommands for perf commands
- if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched) ]]; then
+ if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|data) ]]; then
subcmds=$($cmd $prev_skip_opts --list-cmds)
__perfcomp_colon "$subcmds" "$cur"
fi
next prev parent reply other threads:[~2015-03-22 10:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 13:35 [PATCH 00/13] perf tools: Make some improvements and fixes Yunlong Song
2015-03-18 13:35 ` [PATCH 01/13] perf tools: Fix the bash completion for listing options of perf subcommand Yunlong Song
2015-03-22 10:09 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 02/13] perf tools: Fix the bash completion for listing subsubcommands " Yunlong Song
2015-03-22 10:09 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 03/13] perf tools: Provide the right bash completion for listing options of perf subcommand subsubcommand Yunlong Song
2015-03-22 10:09 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 04/13] perf tools: Fix the bash completion for listing events of perf subcommand record|stat|top -e Yunlong Song
2015-03-22 10:10 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 05/13] perf tools: Fix the bash completion to support listing events for --event Yunlong Song
2015-03-22 10:10 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 06/13] perf tools: Fix the bash completion for listing subcommands of perf Yunlong Song
2015-03-22 10:10 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 07/13] perf tools: Add the bash completion for listing subsubcommands of perf data Yunlong Song
2015-03-22 10:11 ` tip-bot for Yunlong Song [this message]
2015-03-18 13:35 ` [PATCH 08/13] perf tools: Add the bash completion for listing subsubcommands of perf help Yunlong Song
2015-03-22 10:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 09/13] perf tools: Add the bash completion for listing subsubcommands of perf script Yunlong Song
2015-03-22 10:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 10/13] perf tools: Add the bash completion for listing subsubcommands of perf test Yunlong Song
2015-03-22 10:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 11/13] perf tools: Add the bash completion for listing subsubcommands of perf timechart Yunlong Song
2015-03-22 10:12 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 12/13] perf tools: Add the bash completion for listing subsubcommands of perf trace Yunlong Song
2015-03-22 10:12 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 13/13] perf tools: Avoid confusion with preloaded bash function for perf bash completion Yunlong Song
2015-03-22 10:12 ` [tip:perf/core] " tip-bot for Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-01b7160bc6674912f6b7043bbf58d66e62e41054@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
--cc=yunlong.song@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome