From: tip-bot for Yunlong Song <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, wangnan0@huawei.com,
linux-kernel@vger.kernel.org, paulus@samba.org,
yunlong.song@huawei.com, tglx@linutronix.de, mingo@kernel.org,
a.p.zijlstra@chello.nl, hpa@zytor.com
Subject: [tip:perf/core] perf tools: Fix the bash completion for listing subsubcommands of perf subcommand
Date: Sun, 22 Mar 2015 03:09:29 -0700 [thread overview]
Message-ID: <tip-67afff485b2ce742374edb2e17d21e2bc664eb1f@git.kernel.org> (raw)
In-Reply-To: <1426685758-25488-3-git-send-email-yunlong.song@huawei.com>
Commit-ID: 67afff485b2ce742374edb2e17d21e2bc664eb1f
Gitweb: http://git.kernel.org/tip/67afff485b2ce742374edb2e17d21e2bc664eb1f
Author: Yunlong Song <yunlong.song@huawei.com>
AuthorDate: Wed, 18 Mar 2015 21:35:47 +0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 19 Mar 2015 13:49:20 -0300
perf tools: Fix the bash completion for listing subsubcommands of perf subcommand
The bash completion does not support listing subsubcommands for 'perf
kvm|kmem|mem|lock|sched --<long option> <TAB>', where 'kvm|kmem|mem|
lock|sched' are all subcommands of perf.
Example:
Before this patch:
$ perf kvm --verbose <TAB>
$
As shown above, the subsubcommands of perf kvm does not come out.
After this patch:
$ perf kvm --verbose <TAB>
buildid-list diff record report stat
top
As shown above, the subsubcommands of perf kvm can come out now.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1426685758-25488-3-git-send-email-yunlong.song@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/perf-completion.sh | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index 4822ed3..bbb61d0 100644
--- a/tools/perf/perf-completion.sh
+++ b/tools/perf/perf-completion.sh
@@ -100,6 +100,23 @@ __perfcomp_colon ()
__ltrim_colon_completions $cur
}
+__perf_prev_skip_opts ()
+{
+ local i cmd_ cmds_
+
+ let i=cword-1
+ cmds_=$($cmd --list-cmds)
+ prev_skip_opts=()
+ while [ $i -ge 0 ]; do
+ for cmd_ in $cmds_; do
+ if [[ ${words[i]} == $cmd_ ]]; then
+ prev_skip_opts=${words[i]}
+ return
+ fi
+ done
+ ((i--))
+ done
+}
__perf_main ()
{
local cmd
@@ -107,6 +124,8 @@ __perf_main ()
cmd=${words[0]}
COMPREPLY=()
+ # Skip options backward and find the last perf command
+ __perf_prev_skip_opts
# List perf subcommands or long options
if [ $cword -eq 1 ]; then
if [[ $cur == --* ]]; then
@@ -121,8 +140,8 @@ __perf_main ()
__perfcomp_colon "$evts" "$cur"
else
# List subcommands for perf commands
- if [[ $prev == @(kvm|kmem|mem|lock|sched) ]]; then
- subcmds=$($cmd $prev --list-cmds)
+ if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched) ]]; then
+ subcmds=$($cmd $prev_skip_opts --list-cmds)
__perfcomp_colon "$subcmds" "$cur"
fi
# List long option names
next prev parent reply other threads:[~2015-03-22 10:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 13:35 [PATCH 00/13] perf tools: Make some improvements and fixes Yunlong Song
2015-03-18 13:35 ` [PATCH 01/13] perf tools: Fix the bash completion for listing options of perf subcommand Yunlong Song
2015-03-22 10:09 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 02/13] perf tools: Fix the bash completion for listing subsubcommands " Yunlong Song
2015-03-22 10:09 ` tip-bot for Yunlong Song [this message]
2015-03-18 13:35 ` [PATCH 03/13] perf tools: Provide the right bash completion for listing options of perf subcommand subsubcommand Yunlong Song
2015-03-22 10:09 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 04/13] perf tools: Fix the bash completion for listing events of perf subcommand record|stat|top -e Yunlong Song
2015-03-22 10:10 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 05/13] perf tools: Fix the bash completion to support listing events for --event Yunlong Song
2015-03-22 10:10 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 06/13] perf tools: Fix the bash completion for listing subcommands of perf Yunlong Song
2015-03-22 10:10 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 07/13] perf tools: Add the bash completion for listing subsubcommands of perf data Yunlong Song
2015-03-22 10:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 08/13] perf tools: Add the bash completion for listing subsubcommands of perf help Yunlong Song
2015-03-22 10:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 09/13] perf tools: Add the bash completion for listing subsubcommands of perf script Yunlong Song
2015-03-22 10:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 10/13] perf tools: Add the bash completion for listing subsubcommands of perf test Yunlong Song
2015-03-22 10:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 11/13] perf tools: Add the bash completion for listing subsubcommands of perf timechart Yunlong Song
2015-03-22 10:12 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 12/13] perf tools: Add the bash completion for listing subsubcommands of perf trace Yunlong Song
2015-03-22 10:12 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-18 13:35 ` [PATCH 13/13] perf tools: Avoid confusion with preloaded bash function for perf bash completion Yunlong Song
2015-03-22 10:12 ` [tip:perf/core] " tip-bot for Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-67afff485b2ce742374edb2e17d21e2bc664eb1f@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
--cc=yunlong.song@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome