* [PATCH 1/1] x86/idt: remove superfluous ALIGNment
@ 2017-08-31 12:16 Jiri Slaby
2017-08-31 13:49 ` [tip:x86/apic] x86/idt: Remove " tip-bot for Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2017-08-31 12:16 UTC (permalink / raw)
To: mingo
Cc: tglx, hpa, x86, linux-kernel, Jiri Slaby, Andy Lutomirski,
Borislav Petkov, Brian Gerst, Denys Vlasenko, Josh Poimboeuf,
Linus Torvalds, Peter Zijlstra, Steven Rostedt, Ingo Molnar
Commit 87e81786b13b ("x86/idt: Move early IDT setup out of 32-bit asm")
switched early_ignore_irq to use ENTRY. ENTRY aligns the code, so there
is no need for one more ALIGN right before the function.
And add one \n after the function to separate it from the data.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/head_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index a615a5efa8ec..9ed3074d0d27 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -465,7 +465,6 @@ early_idt_handler_common:
ENDPROC(early_idt_handler_common)
/* This is the default interrupt "handler" :-) */
- ALIGN
ENTRY(early_ignore_irq)
cld
#ifdef CONFIG_PRINTK
@@ -502,6 +501,7 @@ hlt_loop:
hlt
jmp hlt_loop
ENDPROC(early_ignore_irq)
+
__INITDATA
.align 4
GLOBAL(early_recursion_flag)
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/apic] x86/idt: Remove superfluous ALIGNment
2017-08-31 12:16 [PATCH 1/1] x86/idt: remove superfluous ALIGNment Jiri Slaby
@ 2017-08-31 13:49 ` tip-bot for Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jiri Slaby @ 2017-08-31 13:49 UTC (permalink / raw)
To: linux-tip-commits
Cc: torvalds, dvlasenk, linux-kernel, luto, tglx, jslaby, peterz, bp,
hpa, rostedt, mingo, brgerst, jpoimboe
Commit-ID: 04b5de3a8f54fad8bb838827de85381bc6a5bc61
Gitweb: http://git.kernel.org/tip/04b5de3a8f54fad8bb838827de85381bc6a5bc61
Author: Jiri Slaby <jslaby@suse.cz>
AuthorDate: Thu, 31 Aug 2017 14:16:53 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 31 Aug 2017 15:47:02 +0200
x86/idt: Remove superfluous ALIGNment
Commit 87e81786b13b ("x86/idt: Move early IDT setup out of 32-bit asm")
switched early_ignore_irq to use ENTRY. ENTRY aligns the code, so there
is no need for one more ALIGN right before the function.
And add one \n after the function to separate it from the data.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Link: http://lkml.kernel.org/r/20170831121653.28917-1-jslaby@suse.cz
---
arch/x86/kernel/head_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index a615a5e..9ed3074 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -465,7 +465,6 @@ early_idt_handler_common:
ENDPROC(early_idt_handler_common)
/* This is the default interrupt "handler" :-) */
- ALIGN
ENTRY(early_ignore_irq)
cld
#ifdef CONFIG_PRINTK
@@ -502,6 +501,7 @@ hlt_loop:
hlt
jmp hlt_loop
ENDPROC(early_ignore_irq)
+
__INITDATA
.align 4
GLOBAL(early_recursion_flag)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-31 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 12:16 [PATCH 1/1] x86/idt: remove superfluous ALIGNment Jiri Slaby
2017-08-31 13:49 ` [tip:x86/apic] x86/idt: Remove " tip-bot for Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome