* Re: [patch] intel_idle: convert i7300_idle_lock to raw spinlock
[not found] <1323258522.5057.73.camel@marge.simson.net>
@ 2011-12-07 13:05 ` Steven Rostedt
2011-12-07 13:46 ` Mike Galbraith
2013-02-14 17:54 ` [tip:core/locking] intel_idle: Convert i7300_idle_lock to raw_spinlock tip-bot for Mike Galbraith
2013-02-22 12:28 ` tip-bot for Mike Galbraith
2 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2011-12-07 13:05 UTC (permalink / raw)
To: Mike Galbraith; +Cc: linux-rt-users, Thomas Gleixner, LKML
Looks as this should also go mainline (Cc'd LKML)
Note, as I want to release 3.0.12-rt30 today, this wont make it. It will
have to wait till -rt31.
-- Steve
On Wed, 2011-12-07 at 12:48 +0100, Mike Galbraith wrote:
> 24 core Intel box's first exposure to 3.0.12-rt30-rc3 didn't go well.
>
> [ 27.104159] i7300_idle: loaded v1.55
> [ 27.104192] BUG: scheduling while atomic: swapper/2/0/0x00000002
> [ 27.104309] Pid: 0, comm: swapper/2 Tainted: G N 3.0.12-rt30-rc3-rt #1
> [ 27.104317] Call Trace:
> [ 27.104338] [<ffffffff810046a5>] dump_trace+0x85/0x2e0
> [ 27.104372] [<ffffffff8144eb00>] thread_return+0x12b/0x30b
> [ 27.104381] [<ffffffff8144f1b9>] schedule+0x29/0xb0
> [ 27.104389] [<ffffffff814506e5>] rt_spin_lock_slowlock+0xc5/0x240
> [ 27.104401] [<ffffffffa01f818f>] i7300_idle_notifier+0x3f/0x360 [i7300_idle]
> [ 27.104415] [<ffffffff814546c7>] notifier_call_chain+0x37/0x70
> [ 27.104426] [<ffffffff81454748>] __atomic_notifier_call_chain+0x48/0x70
> [ 27.104439] [<ffffffff81001a39>] cpu_idle+0x89/0xb0
> [ 27.104449] bad: scheduling from the idle thread!
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
>
> ---
> drivers/idle/i7300_idle.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Index: linux-3.2-rt/drivers/idle/i7300_idle.c
> ===================================================================
> --- linux-3.2-rt.orig/drivers/idle/i7300_idle.c
> +++ linux-3.2-rt/drivers/idle/i7300_idle.c
> @@ -75,7 +75,7 @@ static unsigned long past_skip;
>
> static struct pci_dev *fbd_dev;
>
> -static spinlock_t i7300_idle_lock;
> +static raw_spinlock_t i7300_idle_lock;
> static int i7300_idle_active;
>
> static u8 i7300_idle_thrtctl_saved;
> @@ -457,7 +457,7 @@ static int i7300_idle_notifier(struct no
> idle_begin_time = ktime_get();
> }
>
> - spin_lock_irqsave(&i7300_idle_lock, flags);
> + raw_spin_lock_irqsave(&i7300_idle_lock, flags);
> if (val == IDLE_START) {
>
> cpumask_set_cpu(smp_processor_id(), idle_cpumask);
> @@ -506,7 +506,7 @@ static int i7300_idle_notifier(struct no
> }
> }
> end:
> - spin_unlock_irqrestore(&i7300_idle_lock, flags);
> + raw_spin_unlock_irqrestore(&i7300_idle_lock, flags);
> return 0;
> }
>
> @@ -554,7 +554,7 @@ struct debugfs_file_info {
>
> static int __init i7300_idle_init(void)
> {
> - spin_lock_init(&i7300_idle_lock);
> + raw_spin_lock_init(&i7300_idle_lock);
> total_us = 0;
>
> if (i7300_idle_platform_probe(&fbd_dev, &ioat_dev, forceload))
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] intel_idle: convert i7300_idle_lock to raw spinlock
2011-12-07 13:05 ` [patch] intel_idle: convert i7300_idle_lock to raw spinlock Steven Rostedt
@ 2011-12-07 13:46 ` Mike Galbraith
0 siblings, 0 replies; 4+ messages in thread
From: Mike Galbraith @ 2011-12-07 13:46 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linux-rt-users, Thomas Gleixner, LKML
On Wed, 2011-12-07 at 08:05 -0500, Steven Rostedt wrote:
> Looks as this should also go mainline (Cc'd LKML)
>
> Note, as I want to release 3.0.12-rt30 today, this wont make it. It will
> have to wait till -rt31.
No hurry. (20 synchronized core jitter test was horrid).
> -- Steve
>
> On Wed, 2011-12-07 at 12:48 +0100, Mike Galbraith wrote:
> > 24 core Intel box's first exposure to 3.0.12-rt30-rc3 didn't go well.
> >
> > [ 27.104159] i7300_idle: loaded v1.55
> > [ 27.104192] BUG: scheduling while atomic: swapper/2/0/0x00000002
> > [ 27.104309] Pid: 0, comm: swapper/2 Tainted: G N 3.0.12-rt30-rc3-rt #1
> > [ 27.104317] Call Trace:
> > [ 27.104338] [<ffffffff810046a5>] dump_trace+0x85/0x2e0
> > [ 27.104372] [<ffffffff8144eb00>] thread_return+0x12b/0x30b
> > [ 27.104381] [<ffffffff8144f1b9>] schedule+0x29/0xb0
> > [ 27.104389] [<ffffffff814506e5>] rt_spin_lock_slowlock+0xc5/0x240
> > [ 27.104401] [<ffffffffa01f818f>] i7300_idle_notifier+0x3f/0x360 [i7300_idle]
> > [ 27.104415] [<ffffffff814546c7>] notifier_call_chain+0x37/0x70
> > [ 27.104426] [<ffffffff81454748>] __atomic_notifier_call_chain+0x48/0x70
> > [ 27.104439] [<ffffffff81001a39>] cpu_idle+0x89/0xb0
> > [ 27.104449] bad: scheduling from the idle thread!
> >
> > Signed-off-by: Mike Galbraith <efault@gmx.de>
> >
> > ---
> > drivers/idle/i7300_idle.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > Index: linux-3.2-rt/drivers/idle/i7300_idle.c
> > ===================================================================
> > --- linux-3.2-rt.orig/drivers/idle/i7300_idle.c
> > +++ linux-3.2-rt/drivers/idle/i7300_idle.c
> > @@ -75,7 +75,7 @@ static unsigned long past_skip;
> >
> > static struct pci_dev *fbd_dev;
> >
> > -static spinlock_t i7300_idle_lock;
> > +static raw_spinlock_t i7300_idle_lock;
> > static int i7300_idle_active;
> >
> > static u8 i7300_idle_thrtctl_saved;
> > @@ -457,7 +457,7 @@ static int i7300_idle_notifier(struct no
> > idle_begin_time = ktime_get();
> > }
> >
> > - spin_lock_irqsave(&i7300_idle_lock, flags);
> > + raw_spin_lock_irqsave(&i7300_idle_lock, flags);
> > if (val == IDLE_START) {
> >
> > cpumask_set_cpu(smp_processor_id(), idle_cpumask);
> > @@ -506,7 +506,7 @@ static int i7300_idle_notifier(struct no
> > }
> > }
> > end:
> > - spin_unlock_irqrestore(&i7300_idle_lock, flags);
> > + raw_spin_unlock_irqrestore(&i7300_idle_lock, flags);
> > return 0;
> > }
> >
> > @@ -554,7 +554,7 @@ struct debugfs_file_info {
> >
> > static int __init i7300_idle_init(void)
> > {
> > - spin_lock_init(&i7300_idle_lock);
> > + raw_spin_lock_init(&i7300_idle_lock);
> > total_us = 0;
> >
> > if (i7300_idle_platform_probe(&fbd_dev, &ioat_dev, forceload))
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:core/locking] intel_idle: Convert i7300_idle_lock to raw_spinlock
[not found] <1323258522.5057.73.camel@marge.simson.net>
2011-12-07 13:05 ` [patch] intel_idle: convert i7300_idle_lock to raw spinlock Steven Rostedt
@ 2013-02-14 17:54 ` tip-bot for Mike Galbraith
2013-02-22 12:28 ` tip-bot for Mike Galbraith
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Mike Galbraith @ 2013-02-14 17:54 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, rostedt, efault, andrew.d.henroid, tglx
Commit-ID: 56384eba0f06a834e4c202d0a65e14f55896b67f
Gitweb: http://git.kernel.org/tip/56384eba0f06a834e4c202d0a65e14f55896b67f
Author: Mike Galbraith <efault@gmx.de>
AuthorDate: Wed, 7 Dec 2011 12:48:42 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 14 Feb 2013 18:39:06 +0100
intel_idle: Convert i7300_idle_lock to raw_spinlock
24 core Intel box's first exposure to 3.0.12-rt30-rc3 didn't go well.
[ 27.104159] i7300_idle: loaded v1.55
[ 27.104192] BUG: scheduling while atomic: swapper/2/0/0x00000002
[ 27.104309] Pid: 0, comm: swapper/2 Tainted: G N 3.0.12-rt30-rc3-rt #1
[ 27.104317] Call Trace:
[ 27.104338] [<ffffffff810046a5>] dump_trace+0x85/0x2e0
[ 27.104372] [<ffffffff8144eb00>] thread_return+0x12b/0x30b
[ 27.104381] [<ffffffff8144f1b9>] schedule+0x29/0xb0
[ 27.104389] [<ffffffff814506e5>] rt_spin_lock_slowlock+0xc5/0x240
[ 27.104401] [<ffffffffa01f818f>] i7300_idle_notifier+0x3f/0x360 [i7300_idle]
[ 27.104415] [<ffffffff814546c7>] notifier_call_chain+0x37/0x70
[ 27.104426] [<ffffffff81454748>] __atomic_notifier_call_chain+0x48/0x70
[ 27.104439] [<ffffffff81001a39>] cpu_idle+0x89/0xb0
[ 27.104449] bad: scheduling from the idle thread!
This lock is taken from interrupt disabled context in the guts of
idle. Convert it to a raw_spinlock.
Signed-off-by: Mike Galbraith <efault@gmx.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andy Henroid <andrew.d.henroid@intel.com>
Link: http://lkml.kernel.org/r/1323258522.5057.73.camel@marge.simson.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/idle/i7300_idle.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/idle/i7300_idle.c b/drivers/idle/i7300_idle.c
index fa080eb..ffeebc7 100644
--- a/drivers/idle/i7300_idle.c
+++ b/drivers/idle/i7300_idle.c
@@ -75,7 +75,7 @@ static unsigned long past_skip;
static struct pci_dev *fbd_dev;
-static spinlock_t i7300_idle_lock;
+static raw_spinlock_t i7300_idle_lock;
static int i7300_idle_active;
static u8 i7300_idle_thrtctl_saved;
@@ -457,7 +457,7 @@ static int i7300_idle_notifier(struct notifier_block *nb, unsigned long val,
idle_begin_time = ktime_get();
}
- spin_lock_irqsave(&i7300_idle_lock, flags);
+ raw_spin_lock_irqsave(&i7300_idle_lock, flags);
if (val == IDLE_START) {
cpumask_set_cpu(smp_processor_id(), idle_cpumask);
@@ -506,7 +506,7 @@ static int i7300_idle_notifier(struct notifier_block *nb, unsigned long val,
}
}
end:
- spin_unlock_irqrestore(&i7300_idle_lock, flags);
+ raw_spin_unlock_irqrestore(&i7300_idle_lock, flags);
return 0;
}
@@ -548,7 +548,7 @@ struct debugfs_file_info {
static int __init i7300_idle_init(void)
{
- spin_lock_init(&i7300_idle_lock);
+ raw_spin_lock_init(&i7300_idle_lock);
total_us = 0;
if (i7300_idle_platform_probe(&fbd_dev, &ioat_dev, forceload))
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip:core/locking] intel_idle: Convert i7300_idle_lock to raw_spinlock
[not found] <1323258522.5057.73.camel@marge.simson.net>
2011-12-07 13:05 ` [patch] intel_idle: convert i7300_idle_lock to raw spinlock Steven Rostedt
2013-02-14 17:54 ` [tip:core/locking] intel_idle: Convert i7300_idle_lock to raw_spinlock tip-bot for Mike Galbraith
@ 2013-02-22 12:28 ` tip-bot for Mike Galbraith
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Mike Galbraith @ 2013-02-22 12:28 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, rostedt, efault, andrew.d.henroid, tglx
Commit-ID: 066361a7c58cb6c8b18c7ce0ee8527bb1ce58460
Gitweb: http://git.kernel.org/tip/066361a7c58cb6c8b18c7ce0ee8527bb1ce58460
Author: Mike Galbraith <efault@gmx.de>
AuthorDate: Wed, 7 Dec 2011 12:48:42 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 19 Feb 2013 08:42:47 +0100
intel_idle: Convert i7300_idle_lock to raw_spinlock
24 core Intel box's first exposure to 3.0.12-rt30-rc3 didn't go well.
[ 27.104159] i7300_idle: loaded v1.55
[ 27.104192] BUG: scheduling while atomic: swapper/2/0/0x00000002
[ 27.104309] Pid: 0, comm: swapper/2 Tainted: G N 3.0.12-rt30-rc3-rt #1
[ 27.104317] Call Trace:
[ 27.104338] [<ffffffff810046a5>] dump_trace+0x85/0x2e0
[ 27.104372] [<ffffffff8144eb00>] thread_return+0x12b/0x30b
[ 27.104381] [<ffffffff8144f1b9>] schedule+0x29/0xb0
[ 27.104389] [<ffffffff814506e5>] rt_spin_lock_slowlock+0xc5/0x240
[ 27.104401] [<ffffffffa01f818f>] i7300_idle_notifier+0x3f/0x360 [i7300_idle]
[ 27.104415] [<ffffffff814546c7>] notifier_call_chain+0x37/0x70
[ 27.104426] [<ffffffff81454748>] __atomic_notifier_call_chain+0x48/0x70
[ 27.104439] [<ffffffff81001a39>] cpu_idle+0x89/0xb0
[ 27.104449] bad: scheduling from the idle thread!
This lock is taken from interrupt disabled context in the guts of
idle. Convert it to a raw_spinlock.
Signed-off-by: Mike Galbraith <efault@gmx.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andy Henroid <andrew.d.henroid@intel.com>
Link: http://lkml.kernel.org/r/1323258522.5057.73.camel@marge.simson.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/idle/i7300_idle.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/idle/i7300_idle.c b/drivers/idle/i7300_idle.c
index fa080eb..ffeebc7 100644
--- a/drivers/idle/i7300_idle.c
+++ b/drivers/idle/i7300_idle.c
@@ -75,7 +75,7 @@ static unsigned long past_skip;
static struct pci_dev *fbd_dev;
-static spinlock_t i7300_idle_lock;
+static raw_spinlock_t i7300_idle_lock;
static int i7300_idle_active;
static u8 i7300_idle_thrtctl_saved;
@@ -457,7 +457,7 @@ static int i7300_idle_notifier(struct notifier_block *nb, unsigned long val,
idle_begin_time = ktime_get();
}
- spin_lock_irqsave(&i7300_idle_lock, flags);
+ raw_spin_lock_irqsave(&i7300_idle_lock, flags);
if (val == IDLE_START) {
cpumask_set_cpu(smp_processor_id(), idle_cpumask);
@@ -506,7 +506,7 @@ static int i7300_idle_notifier(struct notifier_block *nb, unsigned long val,
}
}
end:
- spin_unlock_irqrestore(&i7300_idle_lock, flags);
+ raw_spin_unlock_irqrestore(&i7300_idle_lock, flags);
return 0;
}
@@ -548,7 +548,7 @@ struct debugfs_file_info {
static int __init i7300_idle_init(void)
{
- spin_lock_init(&i7300_idle_lock);
+ raw_spin_lock_init(&i7300_idle_lock);
total_us = 0;
if (i7300_idle_platform_probe(&fbd_dev, &ioat_dev, forceload))
^ permalink raw reply [flat|nested] 4+ messages in thread