mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sched/core: remove unused argument for init_[rt|dl]_rq
@ 2015-03-03 11:50 Abel Vesa
  2015-04-02 18:46 ` [tip:sched/core] sched/core: Remove unused argument from init_[ rt|dl]_rq() tip-bot for Abel Vesa
  0 siblings, 1 reply; 2+ messages in thread
From: Abel Vesa @ 2015-03-03 11:50 UTC (permalink / raw)
  To: mingo, peterz; +Cc: linux-kernel, Abel Vesa

Obviously, _rq_ is not used in these two functions, therefore,
there is no reason to be passed as argument.

Signed-off-by: Abel Vesa <abelvesa@gmail.com>
---
 kernel/sched/core.c     | 4 ++--
 kernel/sched/deadline.c | 2 +-
 kernel/sched/rt.c       | 4 ++--
 kernel/sched/sched.h    | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 97fe79c..1074575 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7175,8 +7175,8 @@ void __init sched_init(void)
 		rq->calc_load_active = 0;
 		rq->calc_load_update = jiffies + LOAD_FREQ;
 		init_cfs_rq(&rq->cfs);
-		init_rt_rq(&rq->rt, rq);
-		init_dl_rq(&rq->dl, rq);
+		init_rt_rq(&rq->rt);
+		init_dl_rq(&rq->dl);
 #ifdef CONFIG_FAIR_GROUP_SCHED
 		root_task_group.shares = ROOT_TASK_GROUP_LOAD;
 		INIT_LIST_HEAD(&rq->leaf_cfs_rq_list);
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 3fa8fa6..7c9c1d3 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -69,7 +69,7 @@ void init_dl_bw(struct dl_bw *dl_b)
 	dl_b->total_bw = 0;
 }
 
-void init_dl_rq(struct dl_rq *dl_rq, struct rq *rq)
+void init_dl_rq(struct dl_rq *dl_rq)
 {
 	dl_rq->rb_root = RB_ROOT;
 
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index f4d4b07..7511b2a 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -59,7 +59,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b)
 	raw_spin_unlock(&rt_b->rt_runtime_lock);
 }
 
-void init_rt_rq(struct rt_rq *rt_rq, struct rq *rq)
+void init_rt_rq(struct rt_rq *rt_rq)
 {
 	struct rt_prio_array *array;
 	int i;
@@ -193,7 +193,7 @@ int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
 		if (!rt_se)
 			goto err_free_rq;
 
-		init_rt_rq(rt_rq, cpu_rq(i));
+		init_rt_rq(rt_rq);
 		rt_rq->rt_runtime = tg->rt_bandwidth.rt_runtime;
 		init_tg_rt_entry(tg, rt_rq, rt_se, i, parent->rt_se[i]);
 	}
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index dc0f435..cc919b1 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1643,8 +1643,8 @@ extern void print_rt_stats(struct seq_file *m, int cpu);
 extern void print_dl_stats(struct seq_file *m, int cpu);
 
 extern void init_cfs_rq(struct cfs_rq *cfs_rq);
-extern void init_rt_rq(struct rt_rq *rt_rq, struct rq *rq);
-extern void init_dl_rq(struct dl_rq *dl_rq, struct rq *rq);
+extern void init_rt_rq(struct rt_rq *rt_rq);
+extern void init_dl_rq(struct dl_rq *dl_rq);
 
 extern void cfs_bandwidth_usage_inc(void);
 extern void cfs_bandwidth_usage_dec(void);
-- 
1.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:sched/core] sched/core: Remove unused argument from init_[ rt|dl]_rq()
  2015-03-03 11:50 [PATCH] sched/core: remove unused argument for init_[rt|dl]_rq Abel Vesa
@ 2015-04-02 18:46 ` tip-bot for Abel Vesa
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Abel Vesa @ 2015-04-02 18:46 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: peterz, hpa, tglx, linux-kernel, abelvesa, mingo

Commit-ID:  07c54f7a7ff77bb47bae26e566969e9c4b6fb0c6
Gitweb:     http://git.kernel.org/tip/07c54f7a7ff77bb47bae26e566969e9c4b6fb0c6
Author:     Abel Vesa <abelvesa@gmail.com>
AuthorDate: Tue, 3 Mar 2015 13:50:27 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 2 Apr 2015 17:42:55 +0200

sched/core: Remove unused argument from init_[rt|dl]_rq()

Obviously, 'rq' is not used in these two functions, therefore,
there is no reason for it to be passed as an argument.

Signed-off-by: Abel Vesa <abelvesa@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1425383427-26244-1-git-send-email-abelvesa@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c     | 4 ++--
 kernel/sched/deadline.c | 2 +-
 kernel/sched/rt.c       | 4 ++--
 kernel/sched/sched.h    | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 4b3b688..4c49e75 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7164,8 +7164,8 @@ void __init sched_init(void)
 		rq->calc_load_active = 0;
 		rq->calc_load_update = jiffies + LOAD_FREQ;
 		init_cfs_rq(&rq->cfs);
-		init_rt_rq(&rq->rt, rq);
-		init_dl_rq(&rq->dl, rq);
+		init_rt_rq(&rq->rt);
+		init_dl_rq(&rq->dl);
 #ifdef CONFIG_FAIR_GROUP_SCHED
 		root_task_group.shares = ROOT_TASK_GROUP_LOAD;
 		INIT_LIST_HEAD(&rq->leaf_cfs_rq_list);
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 24c18dc..5e2f99b 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -69,7 +69,7 @@ void init_dl_bw(struct dl_bw *dl_b)
 	dl_b->total_bw = 0;
 }
 
-void init_dl_rq(struct dl_rq *dl_rq, struct rq *rq)
+void init_dl_rq(struct dl_rq *dl_rq)
 {
 	dl_rq->rb_root = RB_ROOT;
 
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index ad02415..575da76 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -64,7 +64,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b)
 static void push_irq_work_func(struct irq_work *work);
 #endif
 
-void init_rt_rq(struct rt_rq *rt_rq, struct rq *rq)
+void init_rt_rq(struct rt_rq *rt_rq)
 {
 	struct rt_prio_array *array;
 	int i;
@@ -205,7 +205,7 @@ int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
 		if (!rt_se)
 			goto err_free_rq;
 
-		init_rt_rq(rt_rq, cpu_rq(i));
+		init_rt_rq(rt_rq);
 		rt_rq->rt_runtime = tg->rt_bandwidth.rt_runtime;
 		init_tg_rt_entry(tg, rt_rq, rt_se, i, parent->rt_se[i]);
 	}
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 91c6736..e0e1299 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1671,8 +1671,8 @@ extern void print_rt_stats(struct seq_file *m, int cpu);
 extern void print_dl_stats(struct seq_file *m, int cpu);
 
 extern void init_cfs_rq(struct cfs_rq *cfs_rq);
-extern void init_rt_rq(struct rt_rq *rt_rq, struct rq *rq);
-extern void init_dl_rq(struct dl_rq *dl_rq, struct rq *rq);
+extern void init_rt_rq(struct rt_rq *rt_rq);
+extern void init_dl_rq(struct dl_rq *dl_rq);
 
 extern void cfs_bandwidth_usage_inc(void);
 extern void cfs_bandwidth_usage_dec(void);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-02 18:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 11:50 [PATCH] sched/core: remove unused argument for init_[rt|dl]_rq Abel Vesa
2015-04-02 18:46 ` [tip:sched/core] sched/core: Remove unused argument from init_[ rt|dl]_rq() tip-bot for Abel Vesa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome