mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Denys Vlasenko <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: keescook@chromium.org, rostedt@goodmis.org, ast@plumgrid.com,
	fweisbec@gmail.com, mingo@kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, wad@chromium.org, bp@alien8.de,
	oleg@redhat.com, luto@amacapital.net,
	torvalds@linux-foundation.org, brgerst@gmail.com,
	tglx@linutronix.de, dvlasenk@redhat.com
Subject: [tip:x86/asm] x86/asm/entry: Zero EXTRA_REGS for stub32_execve() too
Date: Thu, 9 Apr 2015 02:02:33 -0700	[thread overview]
Message-ID: <tip-0f90fb979d7b53d80a6d5cb6e127b4b4b249907e@git.kernel.org> (raw)
In-Reply-To: <1428439424-7258-3-git-send-email-dvlasenk@redhat.com>

Commit-ID:  0f90fb979d7b53d80a6d5cb6e127b4b4b249907e
Gitweb:     http://git.kernel.org/tip/0f90fb979d7b53d80a6d5cb6e127b4b4b249907e
Author:     Denys Vlasenko <dvlasenk@redhat.com>
AuthorDate: Tue, 7 Apr 2015 22:43:39 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 9 Apr 2015 10:31:24 +0200

x86/asm/entry: Zero EXTRA_REGS for stub32_execve() too

The change which affected how execve clears EXTRA_REGS missed
32-bit execve syscalls.

Fix this by using 64-bit execve stub epilogue for them too.

Run-tested.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Drewry <wad@chromium.org>
Link: http://lkml.kernel.org/r/1428439424-7258-3-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/ia32/ia32entry.S  |  2 --
 arch/x86/kernel/entry_64.S | 15 +++++++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index 5d8f987..a821b1c 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -571,8 +571,6 @@ GLOBAL(\label)
 
 	PTREGSCALL stub32_rt_sigreturn, sys32_rt_sigreturn
 	PTREGSCALL stub32_sigreturn, sys32_sigreturn
-	PTREGSCALL stub32_execve, compat_sys_execve
-	PTREGSCALL stub32_execveat, compat_sys_execveat
 	PTREGSCALL stub32_fork, sys_fork
 	PTREGSCALL stub32_vfork, sys_vfork
 
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index f7d9ba6..5380b3a 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -538,6 +538,21 @@ ENTRY(stub_x32_execveat)
 END(stub_x32_execveat)
 #endif
 
+#ifdef CONFIG_IA32_EMULATION
+ENTRY(stub32_execve)
+	CFI_STARTPROC
+	call	compat_sys_execve
+	jmp	return_from_execve
+	CFI_ENDPROC
+END(stub32_execve)
+ENTRY(stub32_execveat)
+	CFI_STARTPROC
+	call	compat_sys_execveat
+	jmp	return_from_execve
+	CFI_ENDPROC
+END(stub32_execveat)
+#endif
+
 /*
  * sigreturn is special because it needs to restore all registers on return.
  * This cannot be done with SYSRET, so use the IRET return path instead.

  parent reply	other threads:[~2015-04-09  9:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 20:43 [PATCH 1/8] x86/asm/entry/64: Use common code for rt_sigreturn epilogue Denys Vlasenko
2015-04-07 20:43 ` [PATCH 2/8] x86/asm/entry/64: Move stub_x32_execve[at] closer to stub_execveat Denys Vlasenko
2015-04-09  9:02   ` [tip:x86/asm] x86/asm/entry/64: Move stub_x32_execvecloser() to stub_execveat() tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 3/8] x86/asm/entry: Zero EXTRA_REGS for stub32_execve[at] too Denys Vlasenko
2015-04-08  2:39   ` Brian Gerst
2015-04-09  9:02   ` tip-bot for Denys Vlasenko [this message]
2015-04-07 20:43 ` [PATCH 4/8] x86/asm/entry/64: optimize [v]fork/clone stubs Denys Vlasenko
2015-04-09  9:02   ` [tip:x86/asm] x86/asm/entry/64: Optimize " tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 5/8] x86/asm/entry/64: remove a redundant jump Denys Vlasenko
2015-04-09  9:03   ` [tip:x86/asm] x86/asm/entry/64: Remove " tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 6/8] x86/asm/entry/64: simplify jumps in ret_from_fork Denys Vlasenko
2015-04-09  9:03   ` [tip:x86/asm] x86/asm/entry/64: Simplify " tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 7/8] x86/asm/entry/64: Remove GET_THREAD_INFO " Denys Vlasenko
2015-04-09  9:03   ` [tip:x86/asm] x86/asm/entry/64: Remove GET_THREAD_INFO() " tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 8/8] x86/asm/entry/64: Reduce padding in execve stubs Denys Vlasenko
2015-04-09  9:04   ` [tip:x86/asm] " tip-bot for Denys Vlasenko
2015-04-09  9:01 ` [tip:x86/asm] x86/asm/entry/64: Use common code for rt_sigreturn( ) epilogue tip-bot for Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-0f90fb979d7b53d80a6d5cb6e127b4b4b249907e@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=ast@plumgrid.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome