mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Denys Vlasenko <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: wad@chromium.org, ast@plumgrid.com, mingo@kernel.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com, luto@amacapital.net,
	torvalds@linux-foundation.org, dvlasenk@redhat.com,
	keescook@chromium.org, brgerst@gmail.com, fweisbec@gmail.com,
	oleg@redhat.com, rostedt@goodmis.org, bp@alien8.de,
	tglx@linutronix.de
Subject: [tip:x86/asm] x86/asm/entry/64: Simplify jumps in ret_from_fork
Date: Thu, 9 Apr 2015 02:03:29 -0700	[thread overview]
Message-ID: <tip-66ad4efa51805964521db03d8aa827a8dd9058b9@git.kernel.org> (raw)
In-Reply-To: <1428439424-7258-6-git-send-email-dvlasenk@redhat.com>

Commit-ID:  66ad4efa51805964521db03d8aa827a8dd9058b9
Gitweb:     http://git.kernel.org/tip/66ad4efa51805964521db03d8aa827a8dd9058b9
Author:     Denys Vlasenko <dvlasenk@redhat.com>
AuthorDate: Tue, 7 Apr 2015 22:43:42 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 9 Apr 2015 10:31:25 +0200

x86/asm/entry/64: Simplify jumps in ret_from_fork

Replace
        test
        jz  1f
        jmp label
    1:

with
        test
        jnz label

Run-tested.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Drewry <wad@chromium.org>
Link: http://lkml.kernel.org/r/1428439424-7258-6-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/entry_64.S | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index e8ddd51..a35e5e4 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -608,18 +608,18 @@ ENTRY(ret_from_fork)
 	RESTORE_EXTRA_REGS
 
 	testl $3,CS(%rsp)			# from kernel_thread?
-	jz   1f
 
 	/*
 	 * By the time we get here, we have no idea whether our pt_regs,
 	 * ti flags, and ti status came from the 64-bit SYSCALL fast path,
 	 * the slow path, or one of the ia32entry paths.
-	 * Use int_ret_from_sys_call to return, since it can safely handle
+	 * Use IRET code path to return, since it can safely handle
 	 * all of the above.
 	 */
-	jmp  int_ret_from_sys_call
+	jnz	int_ret_from_sys_call
 
-1:
+	/* We came from kernel_thread */
+	/* nb: we depend on RESTORE_EXTRA_REGS above */
 	movq %rbp, %rdi
 	call *%rbx
 	movl $0, RAX(%rsp)

  reply	other threads:[~2015-04-09  9:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 20:43 [PATCH 1/8] x86/asm/entry/64: Use common code for rt_sigreturn epilogue Denys Vlasenko
2015-04-07 20:43 ` [PATCH 2/8] x86/asm/entry/64: Move stub_x32_execve[at] closer to stub_execveat Denys Vlasenko
2015-04-09  9:02   ` [tip:x86/asm] x86/asm/entry/64: Move stub_x32_execvecloser() to stub_execveat() tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 3/8] x86/asm/entry: Zero EXTRA_REGS for stub32_execve[at] too Denys Vlasenko
2015-04-08  2:39   ` Brian Gerst
2015-04-09  9:02   ` [tip:x86/asm] x86/asm/entry: Zero EXTRA_REGS for stub32_execve() too tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 4/8] x86/asm/entry/64: optimize [v]fork/clone stubs Denys Vlasenko
2015-04-09  9:02   ` [tip:x86/asm] x86/asm/entry/64: Optimize " tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 5/8] x86/asm/entry/64: remove a redundant jump Denys Vlasenko
2015-04-09  9:03   ` [tip:x86/asm] x86/asm/entry/64: Remove " tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 6/8] x86/asm/entry/64: simplify jumps in ret_from_fork Denys Vlasenko
2015-04-09  9:03   ` tip-bot for Denys Vlasenko [this message]
2015-04-07 20:43 ` [PATCH 7/8] x86/asm/entry/64: Remove GET_THREAD_INFO " Denys Vlasenko
2015-04-09  9:03   ` [tip:x86/asm] x86/asm/entry/64: Remove GET_THREAD_INFO() " tip-bot for Denys Vlasenko
2015-04-07 20:43 ` [PATCH 8/8] x86/asm/entry/64: Reduce padding in execve stubs Denys Vlasenko
2015-04-09  9:04   ` [tip:x86/asm] " tip-bot for Denys Vlasenko
2015-04-09  9:01 ` [tip:x86/asm] x86/asm/entry/64: Use common code for rt_sigreturn( ) epilogue tip-bot for Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-66ad4efa51805964521db03d8aa827a8dd9058b9@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=ast@plumgrid.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome