* [PATCH] sched: parameter "ticks" no longer needed
@ 2012-06-11 6:14 Charles Wang
2012-06-11 9:12 ` [tip:sched/core] sched: Remove unused parameter 'ticks' from calc_global_load() tip-bot for Charles Wang
0 siblings, 1 reply; 2+ messages in thread
From: Charles Wang @ 2012-06-11 6:14 UTC (permalink / raw)
To: linux-kernel; +Cc: Charles Wang, Peter Zijlstra, Ingo Molnar
Parameter "ticks" is not used in calc_global_load now,
so remove it.
calc_load_account_active is called from update_cpu_load_active now.
Signed-off-by: Charles Wang <muming.wq@taobao.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Ingo Molnar <mingo@redhat.com>
---
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 503511f..db4c715 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -145,7 +145,7 @@ extern unsigned long nr_iowait_cpu(int cpu);
extern unsigned long this_cpu_load(void);
-extern void calc_global_load(unsigned long ticks);
+extern void calc_global_load(void);
extern void update_cpu_load_nohz(void);
extern unsigned long get_parent_ip(unsigned long addr);
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 98d7da4..ca07ee0 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2368,7 +2368,7 @@ void get_avenrun(unsigned long *loads, unsigned long offset, int shift)
* calc_load - update the avenrun load estimates 10 ticks after the
* CPUs have updated calc_load_tasks.
*/
-void calc_global_load(unsigned long ticks)
+void calc_global_load(void)
{
long active;
@@ -2396,7 +2396,7 @@ void calc_global_load(unsigned long ticks)
}
/*
- * Called from update_cpu_load() to periodically update this CPU's
+ * Called from update_cpu_load_active() to periodically update this CPU's
* active count.
*/
static void calc_load_account_active(struct rq *this_rq)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 6f46a00..87be8c2 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -1223,7 +1223,7 @@ void do_timer(unsigned long ticks)
{
jiffies_64 += ticks;
update_wall_time();
- calc_global_load(ticks);
+ calc_global_load();
}
/**
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:sched/core] sched: Remove unused parameter 'ticks' from calc_global_load()
2012-06-11 6:14 [PATCH] sched: parameter "ticks" no longer needed Charles Wang
@ 2012-06-11 9:12 ` tip-bot for Charles Wang
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Charles Wang @ 2012-06-11 9:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, muming.wq, a.p.zijlstra, tglx, muming.wq
Commit-ID: 106c1cead7c5c073f375de21760a64f97d9fdd6c
Gitweb: http://git.kernel.org/tip/106c1cead7c5c073f375de21760a64f97d9fdd6c
Author: Charles Wang <muming.wq@gmail.com>
AuthorDate: Mon, 11 Jun 2012 14:14:29 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 11 Jun 2012 10:40:40 +0200
sched: Remove unused parameter 'ticks' from calc_global_load()
Parameter "ticks" is not used in calc_global_load() anymore,
so remove it.
( calc_load_account_active() is called from update_cpu_load_active()
instead. )
Signed-off-by: Charles Wang <muming.wq@taobao.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1339395269-4803-1-git-send-email-muming.wq@taobao.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
include/linux/sched.h | 2 +-
kernel/sched/core.c | 4 ++--
kernel/time/timekeeping.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 4059c0f..a368976 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -144,7 +144,7 @@ extern unsigned long nr_iowait_cpu(int cpu);
extern unsigned long this_cpu_load(void);
-extern void calc_global_load(unsigned long ticks);
+extern void calc_global_load(void);
extern void update_cpu_load_nohz(void);
extern unsigned long get_parent_ip(unsigned long addr);
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d5594a4..dfe673d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2367,7 +2367,7 @@ void get_avenrun(unsigned long *loads, unsigned long offset, int shift)
* calc_load - update the avenrun load estimates 10 ticks after the
* CPUs have updated calc_load_tasks.
*/
-void calc_global_load(unsigned long ticks)
+void calc_global_load(void)
{
long active;
@@ -2395,7 +2395,7 @@ void calc_global_load(unsigned long ticks)
}
/*
- * Called from update_cpu_load() to periodically update this CPU's
+ * Called from update_cpu_load_active() to periodically update this CPU's
* active count.
*/
static void calc_load_account_active(struct rq *this_rq)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 6f46a00..87be8c2 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -1223,7 +1223,7 @@ void do_timer(unsigned long ticks)
{
jiffies_64 += ticks;
update_wall_time();
- calc_global_load(ticks);
+ calc_global_load();
}
/**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-11 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-11 6:14 [PATCH] sched: parameter "ticks" no longer needed Charles Wang
2012-06-11 9:12 ` [tip:sched/core] sched: Remove unused parameter 'ticks' from calc_global_load() tip-bot for Charles Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome