mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Tom Zanussi <tzanussi@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	tzanussi@gmail.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/pebs] perf trace/scripting: Remove extraneous header read
Date: Thu, 4 Mar 2010 16:33:55 GMT	[thread overview]
Message-ID: <tip-10c95f4f41889daaa8130e0bd12209825dbe8d39@git.kernel.org> (raw)
In-Reply-To: <1267599873-8193-2-git-send-email-tzanussi@gmail.com>

Commit-ID:  10c95f4f41889daaa8130e0bd12209825dbe8d39
Gitweb:     http://git.kernel.org/tip/10c95f4f41889daaa8130e0bd12209825dbe8d39
Author:     Tom Zanussi <tzanussi@gmail.com>
AuthorDate: Wed, 3 Mar 2010 01:04:32 -0600
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 4 Mar 2010 12:19:54 +0100

perf trace/scripting: Remove extraneous header read

perf_header__read() is already done in perf_session__open(), so
remove it from the script gen case.

Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Cc: fweisbec@gmail.com
Cc: rostedt@goodmis.org
LKML-Reference: <1267599873-8193-2-git-send-email-tzanussi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/builtin-trace.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 5db687f..b8153db 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -608,7 +608,6 @@ int cmd_trace(int argc, const char **argv, const char *prefix __used)
 			return -1;
 		}
 
-		perf_header__read(&session->header, input);
 		err = scripting_ops->generate_script("perf-trace");
 		goto out;
 	}

  reply	other threads:[~2010-03-04 16:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  7:04 [PATCH 0/2] perf trace: a couple small fixes Tom Zanussi
2010-03-03  7:04 ` [PATCH 1/2] perf trace/scripting: remove extraneous header read Tom Zanussi
2010-03-04 16:33   ` tip-bot for Tom Zanussi [this message]
2010-03-03  7:04 ` [PATCH 2/2] perf trace: don't use pager if scripting Tom Zanussi
2010-03-04 16:34   ` [tip:perf/pebs] perf trace: Don't " tip-bot for Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-10c95f4f41889daaa8130e0bd12209825dbe8d39@git.kernel.org \
    --to=tzanussi@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®