mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Tom Zanussi <tzanussi@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	tzanussi@gmail.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/pebs] perf trace: Don't use pager if scripting
Date: Thu, 4 Mar 2010 16:34:10 GMT	[thread overview]
Message-ID: <tip-cf4fee50282312528e1f8adf73b1831d1d6ae389@git.kernel.org> (raw)
In-Reply-To: <1267599873-8193-3-git-send-email-tzanussi@gmail.com>

Commit-ID:  cf4fee50282312528e1f8adf73b1831d1d6ae389
Gitweb:     http://git.kernel.org/tip/cf4fee50282312528e1f8adf73b1831d1d6ae389
Author:     Tom Zanussi <tzanussi@gmail.com>
AuthorDate: Wed, 3 Mar 2010 01:04:33 -0600
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 4 Mar 2010 12:19:55 +0100

perf trace: Don't use pager if scripting

It's useful for paging through raw traces, but just gets in the
way when scripting.

Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Cc: fweisbec@gmail.com
Cc: rostedt@goodmis.org
LKML-Reference: <1267599873-8193-3-git-send-email-tzanussi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/builtin-trace.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index b8153db..407041d 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -573,7 +573,8 @@ int cmd_trace(int argc, const char **argv, const char *prefix __used)
 
 	if (symbol__init() < 0)
 		return -1;
-	setup_pager();
+	if (!script_name)
+		setup_pager();
 
 	session = perf_session__new(input_name, O_RDONLY, 0);
 	if (session == NULL)

      reply	other threads:[~2010-03-04 16:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  7:04 [PATCH 0/2] perf trace: a couple small fixes Tom Zanussi
2010-03-03  7:04 ` [PATCH 1/2] perf trace/scripting: remove extraneous header read Tom Zanussi
2010-03-04 16:33   ` [tip:perf/pebs] perf trace/scripting: Remove " tip-bot for Tom Zanussi
2010-03-03  7:04 ` [PATCH 2/2] perf trace: don't use pager if scripting Tom Zanussi
2010-03-04 16:34   ` tip-bot for Tom Zanussi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-cf4fee50282312528e1f8adf73b1831d1d6ae389@git.kernel.org \
    --to=tzanussi@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®