mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: ptrace.c only needs export.h and not the full module.h
@ 2013-02-14 20:14 Paul Gortmaker
  2013-02-14 21:01 ` [tip:x86/cleanups] " tip-bot for Paul Gortmaker
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2013-02-14 20:14 UTC (permalink / raw)
  To: linux-kernel; +Cc: x86, Paul Gortmaker, H. Peter Anvin, Jiri Kosina

Commit cb57a2b4cff7edf2a4e32c0163200e9434807e0a ("x86-32: Export
kernel_stack_pointer() for modules") added an include of the
module.h header in conjunction with adding an EXPORT_SYMBOL_GPL
of kernel_stack_pointer.

But module.h should be avoided for simple exports, since it in turn
includes the world.  Swap the module.h for export.h instead.

Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Jiri Kosina <trivial@kernel.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[I didn't see this in tip/auto-latest so vectoring it via trivial]

 arch/x86/kernel/ptrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b629bbe..29a8120 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -22,7 +22,7 @@
 #include <linux/perf_event.h>
 #include <linux/hw_breakpoint.h>
 #include <linux/rcupdate.h>
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/context_tracking.h>
 
 #include <asm/uaccess.h>
-- 
1.8.1.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/cleanups] x86: ptrace.c only needs export.h and not the full module.h
  2013-02-14 20:14 [PATCH] x86: ptrace.c only needs export.h and not the full module.h Paul Gortmaker
@ 2013-02-14 21:01 ` tip-bot for Paul Gortmaker
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Paul Gortmaker @ 2013-02-14 21:01 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, trivial, tglx, hpa, paul.gortmaker

Commit-ID:  19348e749e9515c429f5d561d2f2c724862a4bee
Gitweb:     http://git.kernel.org/tip/19348e749e9515c429f5d561d2f2c724862a4bee
Author:     Paul Gortmaker <paul.gortmaker@windriver.com>
AuthorDate: Thu, 14 Feb 2013 15:14:02 -0500
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Thu, 14 Feb 2013 12:56:12 -0800

x86: ptrace.c only needs export.h and not the full module.h

Commit cb57a2b4cff7edf2a4e32c0163200e9434807e0a ("x86-32: Export
kernel_stack_pointer() for modules") added an include of the
module.h header in conjunction with adding an EXPORT_SYMBOL_GPL
of kernel_stack_pointer.

But module.h should be avoided for simple exports, since it in turn
includes the world.  Swap the module.h for export.h instead.

Cc: Jiri Kosina <trivial@kernel.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Link: http://lkml.kernel.org/r/1360872842-28417-1-git-send-email-paul.gortmaker@windriver.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/kernel/ptrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b629bbe..29a8120 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -22,7 +22,7 @@
 #include <linux/perf_event.h>
 #include <linux/hw_breakpoint.h>
 #include <linux/rcupdate.h>
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/context_tracking.h>
 
 #include <asm/uaccess.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-14 21:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-14 20:14 [PATCH] x86: ptrace.c only needs export.h and not the full module.h Paul Gortmaker
2013-02-14 21:01 ` [tip:x86/cleanups] " tip-bot for Paul Gortmaker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome