* [PATCH] ntp: Make time_esterror and time_maxerror static
@ 2010-01-28 23:02 john stultz
2010-01-29 9:33 ` [tip:timers/core] " tip-bot for john stultz
0 siblings, 1 reply; 2+ messages in thread
From: john stultz @ 2010-01-28 23:02 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Ingo Molnar, richard, lkml
Inspired by Richard's earlier email, I noticed the ntp.c has a few
global values that could be static. This trivial patch cleans that up.
thanks
-john
Make time_esterror and time_maxerror static as no one uses them outside
of ntp.c
Signed-off-by: John Stultz <johnstul@us.ibm.com>
diff --git a/include/linux/timex.h b/include/linux/timex.h
index 94f8fae..7a082b3 100644
--- a/include/linux/timex.h
+++ b/include/linux/timex.h
@@ -238,9 +238,6 @@ extern int tickadj; /* amount of adjustment per tick */
* phase-lock loop variables
*/
extern int time_status; /* clock synchronization status bits */
-extern long time_maxerror; /* maximum error */
-extern long time_esterror; /* estimated error */
-
extern long time_adjust; /* The amount of adjtime left */
extern void ntp_init(void);
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 4800f93..74b1b37 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -58,10 +58,10 @@ static s64 time_offset;
static long time_constant = 2;
/* maximum error (usecs): */
-long time_maxerror = NTP_PHASE_LIMIT;
+static long time_maxerror = NTP_PHASE_LIMIT;
/* estimated error (usecs): */
-long time_esterror = NTP_PHASE_LIMIT;
+static long time_esterror = NTP_PHASE_LIMIT;
/* frequency offset (scaled nsecs/secs): */
static s64 time_freq;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:timers/core] ntp: Make time_esterror and time_maxerror static
2010-01-28 23:02 [PATCH] ntp: Make time_esterror and time_maxerror static john stultz
@ 2010-01-29 9:33 ` tip-bot for john stultz
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for john stultz @ 2010-01-29 9:33 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, johnstul, tglx
Commit-ID: 1f5b8f8a2031ae9507eb67743cad4d424739bfff
Gitweb: http://git.kernel.org/tip/1f5b8f8a2031ae9507eb67743cad4d424739bfff
Author: john stultz <johnstul@us.ibm.com>
AuthorDate: Thu, 28 Jan 2010 15:02:41 -0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 29 Jan 2010 10:15:19 +0100
ntp: Make time_esterror and time_maxerror static
Make time_esterror and time_maxerror static as no one uses them
outside of ntp.c
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Cc: richard@rsk.demon.co.uk
LKML-Reference: <1264719761.3437.47.camel@localhost.localdomain>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
include/linux/timex.h | 3 ---
kernel/time/ntp.c | 4 ++--
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/linux/timex.h b/include/linux/timex.h
index 94f8fae..7a082b3 100644
--- a/include/linux/timex.h
+++ b/include/linux/timex.h
@@ -238,9 +238,6 @@ extern int tickadj; /* amount of adjustment per tick */
* phase-lock loop variables
*/
extern int time_status; /* clock synchronization status bits */
-extern long time_maxerror; /* maximum error */
-extern long time_esterror; /* estimated error */
-
extern long time_adjust; /* The amount of adjtime left */
extern void ntp_init(void);
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 4800f93..74b1b37 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -58,10 +58,10 @@ static s64 time_offset;
static long time_constant = 2;
/* maximum error (usecs): */
-long time_maxerror = NTP_PHASE_LIMIT;
+static long time_maxerror = NTP_PHASE_LIMIT;
/* estimated error (usecs): */
-long time_esterror = NTP_PHASE_LIMIT;
+static long time_esterror = NTP_PHASE_LIMIT;
/* frequency offset (scaled nsecs/secs): */
static s64 time_freq;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-29 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-28 23:02 [PATCH] ntp: Make time_esterror and time_maxerror static john stultz
2010-01-29 9:33 ` [tip:timers/core] " tip-bot for john stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome