mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] irqchip: tegra: propagate IRQ type setting to parent
@ 2015-10-25 15:39 Lucas Stach
  2015-10-26  0:24 ` [tip:irq/urgent] irqchip/tegra: Propagate " tip-bot for Lucas Stach
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2015-10-25 15:39 UTC (permalink / raw)
  To: Thomas Gleixner, Jason Cooper, Marc Zyngier
  Cc: Stephen Warren, Thierry Reding, Alexandre Courbot, linux-kernel,
	linux-tegra

The LIC doesn't deal with the different types of interrupts itself
but needs to forward calls to set the appropriate type to its parent
IRQ controller.

Without this fix all IRQs routed through the LIC will stay at the
initial EDGE type, while most of them should actually be level triggered.

Cc: <stable@vger.kernel.org> # 4.1
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 drivers/irqchip/irq-tegra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 2fd89eb..fd88e68 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -214,6 +214,7 @@ static struct irq_chip tegra_ictlr_chip = {
 	.irq_unmask		= tegra_unmask,
 	.irq_retrigger		= tegra_retrigger,
 	.irq_set_wake		= tegra_set_wake,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
-- 
2.4.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:irq/urgent] irqchip/tegra: Propagate IRQ type setting to parent
  2015-10-25 15:39 [PATCH] irqchip: tegra: propagate IRQ type setting to parent Lucas Stach
@ 2015-10-26  0:24 ` tip-bot for Lucas Stach
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Lucas Stach @ 2015-10-26  0:24 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: gnurou, thierry.reding, dev, jason, linux-kernel, mingo, hpa,
	swarren, tglx, marc.zyngier

Commit-ID:  209da39154837ec1b69fb34f438041939911e4b4
Gitweb:     http://git.kernel.org/tip/209da39154837ec1b69fb34f438041939911e4b4
Author:     Lucas Stach <dev@lynxeye.de>
AuthorDate: Sun, 25 Oct 2015 16:39:12 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 26 Oct 2015 09:20:59 +0900

irqchip/tegra: Propagate IRQ type setting to parent

The LIC doesn't deal with the different types of interrupts itself
but needs to forward calls to set the appropriate type to its parent
IRQ controller.

Without this fix all IRQs routed through the LIC will stay at the
initial EDGE type, while most of them should actually be level triggered.

Fixes: 1eec582158e2 "irqchip: tegra: Add Tegra210 support"
Signed-off-by: Lucas Stach <dev@lynxeye.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: <stable@vger.kernel.org> # 4.1
Link: http://lkml.kernel.org/r/1445787552-13062-1-git-send-email-dev@lynxeye.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-tegra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 2fd89eb..fd88e68 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -214,6 +214,7 @@ static struct irq_chip tegra_ictlr_chip = {
 	.irq_unmask		= tegra_unmask,
 	.irq_retrigger		= tegra_retrigger,
 	.irq_set_wake		= tegra_set_wake,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-26  0:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-25 15:39 [PATCH] irqchip: tegra: propagate IRQ type setting to parent Lucas Stach
2015-10-26  0:24 ` [tip:irq/urgent] irqchip/tegra: Propagate " tip-bot for Lucas Stach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome