mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH tip] locking/static_keys: verify_keys() can be static
  2015-08-03 18:47 [tip:locking/core 19/20] lib/test_static_keys.c:23:19: sparse: symbol 'old_true_key' was not declared. Should it be static? kbuild test robot
@ 2015-08-03 18:47 ` kbuild test robot
  2015-08-05 20:14   ` [tip:locking/core] locking/static_keys: Make verify_keys() static tip-bot for kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-08-03 18:47 UTC (permalink / raw)
  To: Jason Baron
  Cc: kbuild-all, Ingo Molnar, Peter Zijlstra (Intel), tipbuild, linux-kernel


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 test_static_keys.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_static_keys.c b/lib/test_static_keys.c
index 81d8105..c61b299 100644
--- a/lib/test_static_keys.c
+++ b/lib/test_static_keys.c
@@ -70,7 +70,7 @@ static void invert_keys(struct test_key *keys, int size)
 	}
 }
 
-int verify_keys(struct test_key *keys, int size, bool invert)
+static int verify_keys(struct test_key *keys, int size, bool invert)
 {
 	int i;
 	bool ret, init;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:locking/core 19/20] lib/test_static_keys.c:23:19: sparse: symbol 'old_true_key' was not declared. Should it be static?
@ 2015-08-03 18:47 kbuild test robot
  2015-08-03 18:47 ` [PATCH tip] locking/static_keys: verify_keys() can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-08-03 18:47 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core
head:   412758cb26704e5087ca2976ec3b28fb2bdbfad4
commit: 2bf9e0ab08c64ac56067555911a1ae81ebff5f96 [19/20] locking/static_keys: Provide a selftest
reproduce:
  # apt-get install sparse
  git checkout 2bf9e0ab08c64ac56067555911a1ae81ebff5f96
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> lib/test_static_keys.c:23:19: sparse: symbol 'old_true_key' was not declared. Should it be static?
>> lib/test_static_keys.c:24:19: sparse: symbol 'old_false_key' was not declared. Should it be static?
>> lib/test_static_keys.c:27:1: sparse: symbol 'true_key' was not declared. Should it be static?
>> lib/test_static_keys.c:28:1: sparse: symbol 'false_key' was not declared. Should it be static?
>> lib/test_static_keys.c:73:5: sparse: symbol 'verify_keys' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:locking/core] locking/static_keys: Make verify_keys() static
  2015-08-03 18:47 ` [PATCH tip] locking/static_keys: verify_keys() can be static kbuild test robot
@ 2015-08-05 20:14   ` tip-bot for kbuild test robot
  0 siblings, 0 replies; 3+ messages in thread
From: tip-bot for kbuild test robot @ 2015-08-05 20:14 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, mingo, hpa, torvalds, jbaron, fengguang.wu, peterz, tglx

Commit-ID:  20f9ed1568c00bbd9e6af31341d25e06bc3d4a16
Gitweb:     http://git.kernel.org/tip/20f9ed1568c00bbd9e6af31341d25e06bc3d4a16
Author:     kbuild test robot <fengguang.wu@intel.com>
AuthorDate: Tue, 4 Aug 2015 02:47:48 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 5 Aug 2015 09:53:40 +0200

locking/static_keys: Make verify_keys() static

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jason Baron <jbaron@akamai.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20150803184748.GA80634@lkp-ib04
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 lib/test_static_keys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_static_keys.c b/lib/test_static_keys.c
index 81d8105..c61b299 100644
--- a/lib/test_static_keys.c
+++ b/lib/test_static_keys.c
@@ -70,7 +70,7 @@ static void invert_keys(struct test_key *keys, int size)
 	}
 }
 
-int verify_keys(struct test_key *keys, int size, bool invert)
+static int verify_keys(struct test_key *keys, int size, bool invert)
 {
 	int i;
 	bool ret, init;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-05 20:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-03 18:47 [tip:locking/core 19/20] lib/test_static_keys.c:23:19: sparse: symbol 'old_true_key' was not declared. Should it be static? kbuild test robot
2015-08-03 18:47 ` [PATCH tip] locking/static_keys: verify_keys() can be static kbuild test robot
2015-08-05 20:14   ` [tip:locking/core] locking/static_keys: Make verify_keys() static tip-bot for kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®