* [PATCH] irqdesc: Fix missing irq_to_desc export for !CONFIG_SPARSE_IRQ
@ 2014-02-10 18:39 Paul Gortmaker
2014-02-11 9:33 ` [tip:irq/urgent] genirq: Add missing irq_to_desc export for CONFIG_SPARSE_IRQ=n tip-bot for Paul Gortmaker
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2014-02-10 18:39 UTC (permalink / raw)
To: linux-kernel
Cc: sparclinux, linux-next, Paul Gortmaker, Jiri Kosina,
Thomas Gleixner, stable
In allmodconfig builds for sparc and any other arch which does
not set CONFIG_SPARSE_IRQ, the following will be seen at modpost:
CC [M] lib/cpu-notifier-error-inject.o
CC [M] lib/pm-notifier-error-inject.o
ERROR: "irq_to_desc" [drivers/gpio/gpio-mcp23s08.ko] undefined!
make[2]: *** [__modpost] Error 1
This happens because commit 3911ff30f5d1175e2e67e73244405e3492b35c79
("genirq: export handle_edge_irq() and irq_to_desc()") added one
export for it, but there were actually two instances of it, in
an if/else clause for CONFIG_SPARSE_IRQ. Add the second one.
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org # 3.4+
Fixes: 3911ff30f5d1 ("genirq: export handle_edge_irq() and irq_to_desc()")
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 192a302d6cfd..8ab8e9390297 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -274,6 +274,7 @@ struct irq_desc *irq_to_desc(unsigned int irq)
{
return (irq < NR_IRQS) ? irq_desc + irq : NULL;
}
+EXPORT_SYMBOL(irq_to_desc);
static void free_desc(unsigned int irq)
{
--
1.8.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:irq/urgent] genirq: Add missing irq_to_desc export for CONFIG_SPARSE_IRQ=n
2014-02-10 18:39 [PATCH] irqdesc: Fix missing irq_to_desc export for !CONFIG_SPARSE_IRQ Paul Gortmaker
@ 2014-02-11 9:33 ` tip-bot for Paul Gortmaker
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Paul Gortmaker @ 2014-02-11 9:33 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, jkosina, tglx, paul.gortmaker
Commit-ID: 2c45aada341121438affc4cb8d5b4cfaa2813d3d
Gitweb: http://git.kernel.org/tip/2c45aada341121438affc4cb8d5b4cfaa2813d3d
Author: Paul Gortmaker <paul.gortmaker@windriver.com>
AuthorDate: Mon, 10 Feb 2014 13:39:53 -0500
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 11 Feb 2014 10:30:36 +0100
genirq: Add missing irq_to_desc export for CONFIG_SPARSE_IRQ=n
In allmodconfig builds for sparc and any other arch which does
not set CONFIG_SPARSE_IRQ, the following will be seen at modpost:
CC [M] lib/cpu-notifier-error-inject.o
CC [M] lib/pm-notifier-error-inject.o
ERROR: "irq_to_desc" [drivers/gpio/gpio-mcp23s08.ko] undefined!
make[2]: *** [__modpost] Error 1
This happens because commit 3911ff30f5 ("genirq: export
handle_edge_irq() and irq_to_desc()") added one export for it, but
there were actually two instances of it, in an if/else clause for
CONFIG_SPARSE_IRQ. Add the second one.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: stable@vger.kernel.org # 3.4+
Link: http://lkml.kernel.org/r/1392057610-11514-1-git-send-email-paul.gortmaker@windriver.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/irqdesc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 192a302..8ab8e93 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -274,6 +274,7 @@ struct irq_desc *irq_to_desc(unsigned int irq)
{
return (irq < NR_IRQS) ? irq_desc + irq : NULL;
}
+EXPORT_SYMBOL(irq_to_desc);
static void free_desc(unsigned int irq)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-11 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-10 18:39 [PATCH] irqdesc: Fix missing irq_to_desc export for !CONFIG_SPARSE_IRQ Paul Gortmaker
2014-02-11 9:33 ` [tip:irq/urgent] genirq: Add missing irq_to_desc export for CONFIG_SPARSE_IRQ=n tip-bot for Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome