From: tip-bot for Christophe JAILLET <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, bp@suse.de, linux-kernel@vger.kernel.org,
christophe.jaillet@wanadoo.fr, mingo@kernel.org,
tglx@linutronix.de
Subject: [tip:ras/core] RAS/CEC: Check the correct variable in the debugfs error handling
Date: Mon, 26 Jun 2017 07:04:28 -0700 [thread overview]
Message-ID: <tip-32288daf3f2439f57167c03cd679c2eba28923b7@git.kernel.org> (raw)
In-Reply-To: <20170623062440.6726-1-christophe.jaillet@wanadoo.fr>
Commit-ID: 32288daf3f2439f57167c03cd679c2eba28923b7
Gitweb: http://git.kernel.org/tip/32288daf3f2439f57167c03cd679c2eba28923b7
Author: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
AuthorDate: Mon, 26 Jun 2017 14:35:32 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 26 Jun 2017 15:58:57 +0200
RAS/CEC: Check the correct variable in the debugfs error handling
Check the correct variable when handling a potential error from
debugfs_create_file(). Most likely a copy-paste botch.
[ Rewrite commit message. ]
Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170623062440.6726-1-christophe.jaillet@wanadoo.fr
---
drivers/ras/cec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 6aab46d..d0e5d6e 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -481,7 +481,7 @@ static int __init create_debugfs_nodes(void)
count = debugfs_create_file("count_threshold", S_IRUSR | S_IWUSR, d,
&count_threshold, &count_threshold_ops);
- if (!decay) {
+ if (!count) {
pr_warn("Error creating count_threshold debugfs node!\n");
goto err;
}
prev parent reply other threads:[~2017-06-26 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 6:24 [PATCH] RAS: Fix an error checking test in 'create_debugfs_nodes()' Christophe JAILLET
2017-06-23 8:12 ` Borislav Petkov
2017-06-26 14:04 ` tip-bot for Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-32288daf3f2439f57167c03cd679c2eba28923b7@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@suse.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®