* [PATCH] x86/asm/entry/64: fix wrong comment.
@ 2015-03-23 13:03 Denys Vlasenko
2015-03-23 13:30 ` [tip:x86/asm] x86/asm/entry/64: Fix incorrect comment tip-bot for Denys Vlasenko
0 siblings, 1 reply; 2+ messages in thread
From: Denys Vlasenko @ 2015-03-23 13:03 UTC (permalink / raw)
To: Ingo Molnar
Cc: Denys Vlasenko, Linus Torvalds, Steven Rostedt, Borislav Petkov,
H. Peter Anvin, Andy Lutomirski, Oleg Nesterov,
Frederic Weisbecker, Alexei Starovoitov, Will Drewry, Kees Cook,
x86, linux-kernel
The recent old_rsp -> rsp_scratch rename also changed this comment,
but in this case "old_rsp" was not referring to PER_CPU(old_rsp).
Fixing this.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Linus Torvalds <torvalds@linux-foundation.org>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Ingo Molnar <mingo@kernel.org>
CC: Borislav Petkov <bp@alien8.de>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: Andy Lutomirski <luto@amacapital.net>
CC: Oleg Nesterov <oleg@redhat.com>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Alexei Starovoitov <ast@plumgrid.com>
CC: Will Drewry <wad@chromium.org>
CC: Kees Cook <keescook@chromium.org>
CC: x86@kernel.org
CC: linux-kernel@vger.kernel.org
---
arch/x86/kernel/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index 0c91256..7bfdcb3 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -657,7 +657,7 @@ common_interrupt:
ASM_CLAC
addq $-0x80,(%rsp) /* Adjust vector to [-256,-1] range */
interrupt do_IRQ
- /* 0(%rsp): rsp_scratch */
+ /* 0(%rsp): old rsp */
ret_from_intr:
DISABLE_INTERRUPTS(CLBR_NONE)
TRACE_IRQS_OFF
--
1.8.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/asm] x86/asm/entry/64: Fix incorrect comment
2015-03-23 13:03 [PATCH] x86/asm/entry/64: fix wrong comment Denys Vlasenko
@ 2015-03-23 13:30 ` tip-bot for Denys Vlasenko
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Denys Vlasenko @ 2015-03-23 13:30 UTC (permalink / raw)
To: linux-tip-commits
Cc: bp, oleg, mingo, ast, torvalds, luto, keescook, linux-kernel,
dvlasenk, tglx, wad, fweisbec, hpa, rostedt
Commit-ID: 34061f134f70d33296fa56678cee122dd7010401
Gitweb: http://git.kernel.org/tip/34061f134f70d33296fa56678cee122dd7010401
Author: Denys Vlasenko <dvlasenk@redhat.com>
AuthorDate: Mon, 23 Mar 2015 14:03:59 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 23 Mar 2015 14:28:54 +0100
x86/asm/entry/64: Fix incorrect comment
The recent old_rsp -> rsp_scratch rename also changed this
comment, but in this case "old_rsp" was not referring to
PER_CPU(old_rsp).
Fix this.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Will Drewry <wad@chromium.org>
Link: http://lkml.kernel.org/r/1427115839-6397-1-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index 0c91256..9184392 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -657,7 +657,7 @@ common_interrupt:
ASM_CLAC
addq $-0x80,(%rsp) /* Adjust vector to [-256,-1] range */
interrupt do_IRQ
- /* 0(%rsp): rsp_scratch */
+ /* 0(%rsp): old RSP */
ret_from_intr:
DISABLE_INTERRUPTS(CLBR_NONE)
TRACE_IRQS_OFF
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 13:03 [PATCH] x86/asm/entry/64: fix wrong comment Denys Vlasenko
2015-03-23 13:30 ` [tip:x86/asm] x86/asm/entry/64: Fix incorrect comment tip-bot for Denys Vlasenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome