mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Konrad Rzeszutek Wilk <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com,
	konrad.wilk@oracle.com, kernellwp@gmail.com, pbonzini@redhat.com,
	rkrcmar@redhat.com, kvm@vger.kernel.org, bp@alien8.de,
	linux-kernel@vger.kernel.org
Subject: [tip:x86/pti] x86/spectre_v2: Don't check microcode versions when running under hypervisors
Date: Thu, 8 Mar 2018 01:24:50 -0800	[thread overview]
Message-ID: <tip-36268223c1e9981d6cfc33aff8520b3bde4b8114@git.kernel.org> (raw)
In-Reply-To: <20180226213019.GE9497@char.us.oracle.com>

Commit-ID:  36268223c1e9981d6cfc33aff8520b3bde4b8114
Gitweb:     https://git.kernel.org/tip/36268223c1e9981d6cfc33aff8520b3bde4b8114
Author:     Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
AuthorDate: Mon, 26 Feb 2018 09:35:01 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 8 Mar 2018 10:13:02 +0100

x86/spectre_v2: Don't check microcode versions when running under hypervisors

As:

 1) It's known that hypervisors lie about the environment anyhow (host
    mismatch)
 
 2) Even if the hypervisor (Xen, KVM, VMWare, etc) provided a valid
    "correct" value, it all gets to be very murky when migration happens
    (do you provide the "new" microcode of the machine?).

And in reality the cloud vendors are the ones that should make sure that
the microcode that is running is correct and we should just sing lalalala
and trust them.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Wanpeng Li <kernellwp@gmail.com>
Cc: kvm <kvm@vger.kernel.org>
Cc: Krčmář <rkrcmar@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20180226213019.GE9497@char.us.oracle.com

---
 arch/x86/kernel/cpu/intel.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index d19e903214b4..4aa9fd379390 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -144,6 +144,13 @@ static bool bad_spectre_microcode(struct cpuinfo_x86 *c)
 {
 	int i;
 
+	/*
+	 * We know that the hypervisor lie to us on the microcode version so
+	 * we may as well hope that it is running the correct version.
+	 */
+	if (cpu_has(c, X86_FEATURE_HYPERVISOR))
+		return false;
+
 	for (i = 0; i < ARRAY_SIZE(spectre_bad_microcodes); i++) {
 		if (c->x86_model == spectre_bad_microcodes[i].model &&
 		    c->x86_stepping == spectre_bad_microcodes[i].stepping)

  parent reply	other threads:[~2018-03-08  9:25 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  7:23 [PATCH] KVM: X86: Allow userspace to define the microcode version Wanpeng Li
2018-02-26  9:41 ` Borislav Petkov
2018-02-26 10:06   ` Wanpeng Li
2018-02-26 10:49     ` Borislav Petkov
2018-02-26 11:02       ` Wanpeng Li
2018-02-26 11:16         ` Borislav Petkov
2018-02-26 11:25           ` Wanpeng Li
2018-02-26 11:30             ` Borislav Petkov
2018-02-26 11:37               ` Wanpeng Li
2018-02-26 11:44                 ` Borislav Petkov
2018-02-26 11:52                   ` Wanpeng Li
2018-02-26 11:54                   ` Paolo Bonzini
2018-02-26 12:15                     ` Borislav Petkov
2018-02-26 12:16                       ` Paolo Bonzini
2018-02-26 12:18                         ` Paolo Bonzini
2018-02-26 12:22                           ` Borislav Petkov
2018-02-26 12:41                             ` Paolo Bonzini
2018-02-26 13:05                               ` Borislav Petkov
2018-02-26 14:39                               ` Konrad Rzeszutek Wilk
2018-02-26 14:46                                 ` Paolo Bonzini
2018-02-26 19:37                                 ` Borislav Petkov
2018-02-26 20:51                                   ` Konrad Rzeszutek Wilk
2018-02-26 21:30                                     ` Konrad Rzeszutek Wilk
2018-02-27  8:33                                       ` Paolo Bonzini
2018-03-08  9:24                                       ` tip-bot for Konrad Rzeszutek Wilk [this message]
2018-04-17 10:40                               ` Wanpeng Li
2018-04-17 20:24                                 ` Eduardo Habkost
2018-04-18  3:24                                   ` Wanpeng Li
2018-04-18  9:03                                     ` Eduardo Habkost
2018-04-18 10:36                                       ` Paolo Bonzini
2018-04-23 12:58                                         ` Borislav Petkov
2018-04-23 13:08                                           ` Eduardo Habkost
2018-04-23 13:23                                             ` Borislav Petkov
2018-04-23 16:03                                           ` Paolo Bonzini
2018-04-24  2:59                                         ` Wanpeng Li
2018-04-24  3:14                                           ` Konrad Rzeszutek Wilk
2018-04-24  5:09                                             ` Paolo Bonzini
2018-04-24 13:44                                               ` Konrad Rzeszutek Wilk
2018-04-24  2:56                               ` Wanpeng Li
2018-02-26 11:47       ` Paolo Bonzini
2018-02-26 12:20         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-36268223c1e9981d6cfc33aff8520b3bde4b8114@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=kernellwp@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome