mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH trivial sparse fix] guest x86 kvm: fix sparse warning: symbol 'klock_waiting' was not declared. Should it be static
@ 2013-08-16  9:38 Raghavendra K T
  2013-08-19  9:55 ` [tip:x86/spinlocks] x86/kvm/guest: Fix sparse warning: "symbol ' klock_waiting' was not declared as static" tip-bot for Raghavendra K T
  0 siblings, 1 reply; 2+ messages in thread
From: Raghavendra K T @ 2013-08-16  9:38 UTC (permalink / raw)
  To: x86, Jiri Kosina
  Cc: mingo, hpa, gleb, pbonzini, tglx, linux-kernel, Raghavendra K T

It was not declared as static since it was thought to be used by pv-flushtlb earlier.

Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
---
 This should apply on top of tip/spinlocks and fixes the sparse warning
 introduced by pvspinlock patch series.

 arch/x86/kernel/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index b8ef630..56e2fa4 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -529,7 +529,7 @@ arch_initcall(activate_jump_labels);
 #ifdef CONFIG_PARAVIRT_SPINLOCKS
 
 /* Kick a cpu by its apicid. Used to wake up a halted vcpu */
-void kvm_kick_cpu(int cpu)
+static void kvm_kick_cpu(int cpu)
 {
 	int apicid;
 	unsigned long flags = 0;
-- 
1.7.11.7


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/spinlocks] x86/kvm/guest: Fix sparse warning: "symbol ' klock_waiting' was not declared as static"
  2013-08-16  9:38 [PATCH trivial sparse fix] guest x86 kvm: fix sparse warning: symbol 'klock_waiting' was not declared. Should it be static Raghavendra K T
@ 2013-08-19  9:55 ` tip-bot for Raghavendra K T
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Raghavendra K T @ 2013-08-19  9:55 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, trivial, gleb, raghavendra.kt, pbonzini, tglx

Commit-ID:  36bd621337c91a1ecda588e5bbbae8dd9698bae7
Gitweb:     http://git.kernel.org/tip/36bd621337c91a1ecda588e5bbbae8dd9698bae7
Author:     Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
AuthorDate: Fri, 16 Aug 2013 15:08:41 +0530
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 19 Aug 2013 11:49:50 +0200

x86/kvm/guest: Fix sparse warning: "symbol 'klock_waiting' was not declared as static"

It was not declared as static since it was thought to be used by
pv-flushtlb earlier.

Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: <gleb@redhat.com>
Cc: <pbonzini@redhat.com>
Cc: Jiri Kosina <trivial@kernel.org>
Link: http://lkml.kernel.org/r/1376645921-8056-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index b8ef630..56e2fa4 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -529,7 +529,7 @@ arch_initcall(activate_jump_labels);
 #ifdef CONFIG_PARAVIRT_SPINLOCKS
 
 /* Kick a cpu by its apicid. Used to wake up a halted vcpu */
-void kvm_kick_cpu(int cpu)
+static void kvm_kick_cpu(int cpu)
 {
 	int apicid;
 	unsigned long flags = 0;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-19  9:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-16  9:38 [PATCH trivial sparse fix] guest x86 kvm: fix sparse warning: symbol 'klock_waiting' was not declared. Should it be static Raghavendra K T
2013-08-19  9:55 ` [tip:x86/spinlocks] x86/kvm/guest: Fix sparse warning: "symbol ' klock_waiting' was not declared as static" tip-bot for Raghavendra K T

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome