From: tip-bot for Jithu Joseph <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jithu.joseph@intel.com, fenghua.yu@intel.com, tglx@linutronix.de,
hpa@zytor.com, reinette.chatre@intel.com, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: [tip:x86/cache] x86/intel_rdt: Remove redundant assignment
Date: Thu, 5 Oct 2017 04:26:01 -0700 [thread overview]
Message-ID: <tip-3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c@git.kernel.org> (raw)
In-Reply-To: <1507157337-18118-1-git-send-email-jithu.joseph@intel.com>
Commit-ID: 3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c
Gitweb: https://git.kernel.org/tip/3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c
Author: Jithu Joseph <jithu.joseph@intel.com>
AuthorDate: Wed, 4 Oct 2017 15:48:57 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 5 Oct 2017 13:20:32 +0200
x86/intel_rdt: Remove redundant assignment
The assignment to the 'files' variable is immediately overwritten
in the following line. Remove the older assignment, which was meant
specifially for creating control groups files.
Fixes: c7d9aac61311 ("x86/intel_rdt/cqm: Add mkdir support for RDT monitoring")
Reported-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Fenghua Yu <fenghua.yu@intel.com>
Cc: tony.luck@intel.com
Cc: vikas.shivappa@intel.com
Link: https://lkml.kernel.org/r/1507157337-18118-1-git-send-email-jithu.joseph@intel.com
---
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index abd220b..8a61b20 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -1635,7 +1635,6 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
goto out_destroy;
}
- files = RFTYPE_BASE | RFTYPE_CTRL;
files = RFTYPE_BASE | BIT(RF_CTRLSHIFT + rtype);
ret = rdtgroup_add_files(kn, files);
if (ret) {
prev parent reply other threads:[~2017-10-05 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 22:48 [PATCH] " Jithu Joseph
2017-10-05 11:26 ` tip-bot for Jithu Joseph [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c@git.kernel.org \
--to=tipbot@zytor.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome