mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86/intel_rdt: Remove redundant assignment
@ 2017-10-04 22:48 Jithu Joseph
  2017-10-05 11:26 ` [tip:x86/cache] " tip-bot for Jithu Joseph
  0 siblings, 1 reply; 2+ messages in thread
From: Jithu Joseph @ 2017-10-04 22:48 UTC (permalink / raw)
  To: tglx
  Cc: fenghua.yu, tony.luck, vikas.shivappa, mingo, hpa,
	reinette.chatre, x86, linux-kernel, Jithu Joseph

The assignment to the 'files' variable is immediately overwritten
in the following line. Remove the older assignment, which was meant
specifially for creating control groups files.

Fixes: c7d9aac61311 ("x86/intel_rdt/cqm: Add mkdir support for RDT monitoring")
Reported-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Acked-by: Fenghua Yu <fenghua.yu@intel.com>
---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index a869d4a..dc22064 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -1560,7 +1560,6 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
 	if (ret)
 		goto out_destroy;
 
-	files = RFTYPE_BASE | RFTYPE_CTRL;
 	files = RFTYPE_BASE | BIT(RF_CTRLSHIFT + rtype);
 	ret = rdtgroup_add_files(kn, files);
 	if (ret)
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/cache] x86/intel_rdt: Remove redundant assignment
  2017-10-04 22:48 [PATCH] x86/intel_rdt: Remove redundant assignment Jithu Joseph
@ 2017-10-05 11:26 ` tip-bot for Jithu Joseph
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jithu Joseph @ 2017-10-05 11:26 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: jithu.joseph, fenghua.yu, tglx, hpa, reinette.chatre, mingo,
	linux-kernel

Commit-ID:  3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c
Gitweb:     https://git.kernel.org/tip/3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c
Author:     Jithu Joseph <jithu.joseph@intel.com>
AuthorDate: Wed, 4 Oct 2017 15:48:57 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 5 Oct 2017 13:20:32 +0200

x86/intel_rdt: Remove redundant assignment

The assignment to the 'files' variable is immediately overwritten
in the following line. Remove the older assignment, which was meant
specifially for creating control groups files.

Fixes: c7d9aac61311 ("x86/intel_rdt/cqm: Add mkdir support for RDT monitoring")
Reported-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Fenghua Yu <fenghua.yu@intel.com>
Cc: tony.luck@intel.com
Cc: vikas.shivappa@intel.com
Link: https://lkml.kernel.org/r/1507157337-18118-1-git-send-email-jithu.joseph@intel.com

---
 arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index abd220b..8a61b20 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -1635,7 +1635,6 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn,
 		goto out_destroy;
 	}
 
-	files = RFTYPE_BASE | RFTYPE_CTRL;
 	files = RFTYPE_BASE | BIT(RF_CTRLSHIFT + rtype);
 	ret = rdtgroup_add_files(kn, files);
 	if (ret) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-05 11:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04 22:48 [PATCH] x86/intel_rdt: Remove redundant assignment Jithu Joseph
2017-10-05 11:26 ` [tip:x86/cache] " tip-bot for Jithu Joseph

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome