* [PATCH] x86/mm: remove stale comment about kmemcheck
@ 2018-02-19 17:50 Jann Horn
2018-02-20 10:26 ` [tip:x86/pti] x86/mm: Remove stale comment about KMEMCHECK tip-bot for Jann Horn
0 siblings, 1 reply; 2+ messages in thread
From: Jann Horn @ 2018-02-19 17:50 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86; +Cc: linux-kernel
This comment referred to a conditional call to kmemcheck_hide() that was
here until commit 4950276672fc ("kmemcheck: remove annotations"). Now that
kmemcheck has been removed, it doesn't make sense anymore.
Signed-off-by: Jann Horn <jannh@google.com>
---
arch/x86/mm/fault.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 800de815519c..c88573d90f3e 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -1248,10 +1248,6 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code,
tsk = current;
mm = tsk->mm;
- /*
- * Detect and handle instructions that would cause a page fault for
- * both a tracked kernel page and a userspace page.
- */
prefetchw(&mm->mmap_sem);
if (unlikely(kmmio_fault(regs, address)))
--
2.16.1.291.g4437f3f132-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/pti] x86/mm: Remove stale comment about KMEMCHECK
2018-02-19 17:50 [PATCH] x86/mm: remove stale comment about kmemcheck Jann Horn
@ 2018-02-20 10:26 ` tip-bot for Jann Horn
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jann Horn @ 2018-02-20 10:26 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, jpoimboe, luto, peterz, hpa, jannh, linux-kernel,
dvlasenk, tglx, brgerst, torvalds, bp
Commit-ID: 3b3a9268bba62b35a29bafe0931715b1725fdf26
Gitweb: https://git.kernel.org/tip/3b3a9268bba62b35a29bafe0931715b1725fdf26
Author: Jann Horn <jannh@google.com>
AuthorDate: Mon, 19 Feb 2018 18:50:39 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Feb 2018 09:33:39 +0100
x86/mm: Remove stale comment about KMEMCHECK
This comment referred to a conditional call to kmemcheck_hide() that was
here until commit 4950276672fc ("kmemcheck: remove annotations").
Now that kmemcheck has been removed, it doesn't make sense anymore.
Signed-off-by: Jann Horn <jannh@google.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180219175039.253089-1-jannh@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/mm/fault.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 800de81..c88573d 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -1248,10 +1248,6 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code,
tsk = current;
mm = tsk->mm;
- /*
- * Detect and handle instructions that would cause a page fault for
- * both a tracked kernel page and a userspace page.
- */
prefetchw(&mm->mmap_sem);
if (unlikely(kmmio_fault(regs, address)))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-20 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-19 17:50 [PATCH] x86/mm: remove stale comment about kmemcheck Jann Horn
2018-02-20 10:26 ` [tip:x86/pti] x86/mm: Remove stale comment about KMEMCHECK tip-bot for Jann Horn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome