mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/5] perf: Fixes for callchain ip handling and related tests
@ 2018-07-10 13:58 Sandipan Das
  2018-07-10 13:58 ` [PATCH 1/5] perf powerpc: Fix callchain ip filtering Sandipan Das
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Sandipan Das @ 2018-07-10 13:58 UTC (permalink / raw)
  To: acme; +Cc: linux-kernel, jolsa, ravi.bangoria, naveen.n.rao

The first two patches fix the callchain ip filtering mechanism for
powerpc from skipping entries unecessarily by checking the status of
a function's return address in the stack.

The third patch fixes a shell test that fails on powerpc due to a
mismatch in the expected perf script output.

The fourth and fifth patches are generic fixes for the same shell
test.

--

Hi Arnaldo,

This series has fixes for the inet_pton shell test and depends
on the following patches from Kim Phillips:

[1] https://lkml.org/lkml/2018/6/29/570
[2] https://lkml.org/lkml/2018/6/29/568

I did see that you had replied saying that you have applied
these patches to your tree but I still do not see the changes
in the 'perf/core' and 'perf/urgent' branches. Assuming that
you would be pushing these changes, I applied Kim's patches
to my local tree manually before I started working on this
series.

--

Sandipan Das (5):
  perf powerpc: Fix callchain ip filtering
  perf powerpc: Fix callchain ip filtering when return address is in a
    register
  perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64
  perf tests: Fix record+probe_libc_inet_pton.sh to ensure cleanups
  perf tests: Fix record+probe_libc_inet_pton.sh when event exists

 tools/perf/arch/powerpc/util/skip-callchain-idx.c  | 10 ++++--
 .../tests/shell/record+probe_libc_inet_pton.sh     | 36 +++++++++++++++++++---
 2 files changed, 38 insertions(+), 8 deletions(-)

-- 
2.14.4


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64
@ 2019-06-27 10:16 Seeteena Thoufeek
  2019-07-09 11:31 ` [tip:perf/core] " tip-bot for Seeteena Thoufeek
  0 siblings, 1 reply; 13+ messages in thread
From: Seeteena Thoufeek @ 2019-06-27 10:16 UTC (permalink / raw)
  To: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	sandipan, mpetlan, kim.phillips, brueckner, linux-kernel
  Cc: s1seetee

'probe libc's inet_pton & backtrace it with ping' testcase sometimes
fails on powerpc because distro ping binary does not have symbol
information and thus it prints "[unknown]" function name in the
backtrace.

Accept "[unknown]" as valid function name for powerpc as well.

 # perf test -v "probe libc's inet_pton & backtrace it with ping"

Before:

  59: probe libc's inet_pton & backtrace it with ping       :
  --- start ---
  test child forked, pid 79695
  ping 79718 [077] 96483.787025: probe_libc:inet_pton: (7fff83a754c8)
  7fff83a754c8 __GI___inet_pton+0x8 (/usr/lib64/power9/libc-2.28.so)
  7fff83a2b7a0 gaih_inet.constprop.7+0x1020
  (/usr/lib64/power9/libc-2.28.so)
  7fff83a2c170 getaddrinfo+0x160 (/usr/lib64/power9/libc-2.28.so)
  1171830f4 [unknown] (/usr/bin/ping)
  FAIL: expected backtrace entry
  ".*\+0x[[:xdigit:]]+[[:space:]]\(.*/bin/ping.*\)$"
  got "1171830f4 [unknown] (/usr/bin/ping)"
  test child finished with -1
  ---- end ----
  probe libc's inet_pton & backtrace it with ping: FAILED!

After:

  59: probe libc's inet_pton & backtrace it with ping       :
  --- start ---
  test child forked, pid 79085
  ping 79108 [045] 96400.214177: probe_libc:inet_pton: (7fffbb9654c8)
  7fffbb9654c8 __GI___inet_pton+0x8 (/usr/lib64/power9/libc-2.28.so)
  7fffbb91b7a0 gaih_inet.constprop.7+0x1020
  (/usr/lib64/power9/libc-2.28.so)
  7fffbb91c170 getaddrinfo+0x160 (/usr/lib64/power9/libc-2.28.so)
  132e830f4 [unknown] (/usr/bin/ping)
  test child finished with 0
  ---- end ----
  probe libc's inet_pton & backtrace it with ping: Ok

Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
---
 tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
index 61c9f8f..58a99a2 100755
--- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
+++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
@@ -44,7 +44,7 @@ trace_libc_inet_pton_backtrace() {
 		eventattr='max-stack=4'
 		echo "gaih_inet.*\+0x[[:xdigit:]]+[[:space:]]\($libc\)$" >> $expected
 		echo "getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\($libc\)$" >> $expected
-		echo ".*\+0x[[:xdigit:]]+[[:space:]]\(.*/bin/ping.*\)$" >> $expected
+		echo ".*(\+0x[[:xdigit:]]+|\[unknown\])[[:space:]]\(.*/bin/ping.*\)$" >> $expected
 		;;
 	*)
 		eventattr='max-stack=3'
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-07-09 11:31 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-10 13:58 [PATCH 0/5] perf: Fixes for callchain ip handling and related tests Sandipan Das
2018-07-10 13:58 ` [PATCH 1/5] perf powerpc: Fix callchain ip filtering Sandipan Das
2018-07-25 20:45   ` [tip:perf/core] " tip-bot for Sandipan Das
2018-07-10 13:58 ` [PATCH 2/5] perf powerpc: Fix callchain ip filtering when return address is in a register Sandipan Das
2018-07-25 20:45   ` [tip:perf/core] " tip-bot for Sandipan Das
2018-07-10 13:58 ` [PATCH 3/5] perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64 Sandipan Das
2018-07-25 20:46   ` [tip:perf/core] " tip-bot for Sandipan Das
2018-07-10 13:58 ` [PATCH 4/5] perf tests: Fix record+probe_libc_inet_pton.sh to ensure cleanups Sandipan Das
2018-07-25 20:46   ` [tip:perf/core] " tip-bot for Sandipan Das
2018-07-10 13:58 ` [PATCH 5/5] perf tests: Fix record+probe_libc_inet_pton.sh when event exists Sandipan Das
2018-07-25 20:47   ` [tip:perf/core] " tip-bot for Sandipan Das
2018-07-17 19:57 ` [PATCH 0/5] perf: Fixes for callchain ip handling and related tests Arnaldo Carvalho de Melo
2019-06-27 10:16 [PATCH] perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64 Seeteena Thoufeek
2019-07-09 11:31 ` [tip:perf/core] " tip-bot for Seeteena Thoufeek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome